[TT-1016] Swtich from gotestfmt to gotestloghelper #12633
Conversation
tateexon
force-pushed
the
TT-1016-Use-GoTestLogHelper
branch
from
31a1d05 to
b86a7e6
Compare
tateexon
force-pushed
the
TT-1016-Use-GoTestLogHelper
branch
from
a11f469 to
5849ce1
Compare
tateexon
force-pushed
the
TT-1016-Use-GoTestLogHelper
branch
from
5849ce1 to
cf06022
Compare
tateexon
force-pushed
the
TT-1016-Use-GoTestLogHelper
branch
from
cf06022 to
ee69ff8
Compare
tateexon
force-pushed
the
TT-1016-Use-GoTestLogHelper
branch
from
ebc6bc1 to
5be1948
Compare
| with: | ||
| test_command_to_run: cd ./integration-tests && go test -timeout 30m -count=1 -json -test.parallel=${{ matrix.product.nodes }} ${{ steps.build-go-test-command.outputs.run_command }} 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| test_command_to_run: cd ./integration-tests && go test -timeout 30m -count=1 -json -test.parallel=${{ matrix.product.nodes }} ${{ steps.build-go-test-command.outputs.run_command }} 2>&1 | tee /tmp/gotest.log | gotestloghelper -ci -singlepackage |
There was a problem hiding this comment.
how about merging tee /tmp/gotest.log | gotestloghelper -ci -singlepackage to test_command_to_run if opted for gotestloghelper in run-test? Might help in maintenance and updating all run-tests. Can take an input to denote if gotesthelper is preferred.
There was a problem hiding this comment.
That is a good idea. I will be ripping out the run-tests from chainlink-github-actions and moving it to .github soon so I will add this to the changes that would improve the flow there!
| artifacts_location: ./integration-tests/migration/logs | ||
| artifacts_location: | | ||
| ./integration-tests/migration/logs | ||
| /tmp/gotest.log |
There was a problem hiding this comment.
similar as before if gotesthelper is opted /tmp/gotest.log can be added to artifacts_location
|
Makes go test log output less noisy when used. Cleans up things like testing.T.Log prefix, only shows errors, highlights errors in red, copies error messages to the top if there are lots of logs before the error to save you time from having to scroll to the bottom, adds drop downs in CI for individual tests so you can look at specific logs more easily without having to scroll through others. An example of some of the logs on errors: https://github.com/smartcontractkit/chainlink/actions/runs/8605875051/job/23583096855?pr=12633