Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppConfig from ChainScoped #12636

Merged
merged 30 commits into from
Apr 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
10dd057
Remove AppConfig from ChainScoped
dimriou Mar 21, 2024
ad462a1
Fix shell_local
dimriou Mar 21, 2024
6c83d67
Update configs for services
dimriou Mar 21, 2024
02db5eb
Extend relay configs
dimriou Apr 1, 2024
d1257f1
Merge branch 'develop' into fix_configs
dimriou Apr 8, 2024
2ddcf5e
Add DefaultQueryTimeout as arg
dimriou Apr 8, 2024
c5867e3
Fix lint
dimriou Apr 8, 2024
02125d6
Fix test cases in cmd
dimriou Apr 8, 2024
94b7dd3
Add changeset
dimriou Apr 8, 2024
5957e46
Merge branch 'develop' into fix_configs
dimriou Apr 10, 2024
651ec1d
Remove unnecessary OCR check
dimriou Apr 10, 2024
4530827
Merge branch 'develop' into fix_configs
dimriou Apr 11, 2024
42d2bc3
Update chain scoped mock
dimriou Apr 11, 2024
24d0fca
Merge branch 'develop' into fix_configs
dimriou Apr 16, 2024
c8f2957
Merge branch 'develop' into fix_configs
dimriou Apr 17, 2024
aae4c00
Add default cases for relay args
dimriou Apr 17, 2024
efce3a1
Merge branch 'develop' into fix_configs
dimriou Apr 18, 2024
1a5d05c
Remove unused Database config from OCR
dimriou Apr 18, 2024
d64be4b
Add changeset
dimriou Apr 18, 2024
ec8e7ce
Remove DefaultTimeout config from RelayArgs
dimriou Apr 18, 2024
5d58498
Address comments
dimriou Apr 18, 2024
ca25411
Remove unnecessary changeset
dimriou Apr 18, 2024
f0518c1
Remove defaultquerytimeout from RelayConfig
dimriou Apr 18, 2024
48a9b75
Update remaining relays
dimriou Apr 19, 2024
cd3c82f
Handle services collectively
dimriou Apr 19, 2024
66035d7
Merge branch 'develop' into fix_configs
dimriou Apr 22, 2024
d20e5c6
Update relayConfigsWithDefaults
dimriou Apr 22, 2024
3fec5d0
Merge branch 'develop' into fix_configs
dimriou Apr 22, 2024
7910a77
Update configs through JSONConfig
dimriou Apr 22, 2024
8515dd7
Fix lint
dimriou Apr 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test cases in cmd
  • Loading branch information
dimriou committed Apr 8, 2024
commit 02125d6540d1dc2878f853d33edfec53674437d5
3 changes: 3 additions & 0 deletions core/cmd/shell_local_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ func TestShell_RebroadcastTransactions_Txm(t *testing.T) {
app.On("GetSqlxDB").Return(sqlxDB)
app.On("GetKeyStore").Return(keyStore)
app.On("ID").Maybe().Return(uuid.New())
app.On("GetConfig").Return(config)
ethClient := evmtest.NewEthClientMockWithDefaultChain(t)
legacy := cltest.NewLegacyChainsWithMockChain(t, ethClient, config)

Expand Down Expand Up @@ -383,6 +384,7 @@ func TestShell_RebroadcastTransactions_OutsideRange_Txm(t *testing.T) {
app.On("GetSqlxDB").Return(sqlxDB)
app.On("GetKeyStore").Return(keyStore)
app.On("ID").Maybe().Return(uuid.New())
app.On("GetConfig").Return(config)
ethClient := evmtest.NewEthClientMockWithDefaultChain(t)
ethClient.On("Dial", mock.Anything).Return(nil)
legacy := cltest.NewLegacyChainsWithMockChain(t, ethClient, config)
Expand Down Expand Up @@ -487,6 +489,7 @@ func TestShell_RebroadcastTransactions_AddressCheck(t *testing.T) {
if test.shouldError {
require.ErrorContains(t, client.RebroadcastTransactions(c), test.errorContains)
} else {
app.On("GetConfig").Return(config).Once()
require.NoError(t, client.RebroadcastTransactions(c))
}

Expand Down
Loading