[SHIP-1523] Add X Layer #12747
Merged
[SHIP-1523] Add X Layer #12747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1523-xlayer # Conflicts: # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
friedemannf
commented
Apr 29, 2024
| @@ -9,9 +9,9 @@ import ( | |||
| // chainSpecificIsUsable allows for additional logic specific to a particular | |||
| // Config that determines whether a transaction should be used for gas estimation | |||
| func chainSpecificIsUsable(tx evmtypes.Transaction, baseFee *assets.Wei, chainType config.ChainType, minGasPriceWei *assets.Wei) bool { | |||
| if chainType == config.ChainGnosis || chainType == config.ChainXDai { | |||
| if chainType == config.ChainGnosis || chainType == config.ChainXDai || chainType == config.ChainXLayer { | |||
| // GasPrice 0 on most chains is great since it indicates cheap/free transactions. | |||
There was a problem hiding this comment.
cc @samsondav as you seem to have implemented this back then?
There was a problem hiding this comment.
I couldn't find any resources on this for Gnosis, and there don't seem to be any gasless transactions anymore happening on Gnosis. Do you remember what info you based this on?
amit-momin
reviewed
Apr 29, 2024
davidcauchi
previously approved these changes
Apr 30, 2024
friedemannf
dismissed stale reviews from davidcauchi and prashantkumar1982
via
6cf1052
|
amit-momin
approved these changes
Apr 30, 2024
This was referenced Apr 30, 2024
davidcauchi
pushed a commit
that referenced
this pull request
May 6, 2024
* Add X Layer * go mod tidy * Add ChainType for XLayer to ignore transactions with 0 gasPrice * revert switch stmt * update changeset * fix test * add BlockHistoryEstimator test for XLayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds default configs for X Layer, based on the current Polygon zkEVM configs.
Also, add a new
ChainTypeparameter that is used to ignore gasless transactions, similar to what's already being implemented for Gnosis.