Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Install jq when building plugins image #12750

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

cedric-cordenier
Copy link
Contributor

The VERSION file has been replaced with the .version key in the root package json. The version is also now sourced using jq, but jq isn't being installed by the plugins Dockerfile, and so the version is showing up as empty and the core node is panicking on boot.

This adds jq so that the version is correctly set.

@cedric-cordenier cedric-cordenier marked this pull request as ready for review April 9, 2024 09:57
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Maintainability Rating on New Code (required ≥ A)
11.11% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Apr 9, 2024
Merged via the queue into develop with commit 46a6ea2 Apr 9, 2024
104 of 105 checks passed
@cedric-cordenier cedric-cordenier deleted the fix-plugins-build branch April 9, 2024 10:33
@snehaagni snehaagni requested a review from momentmaker April 9, 2024 12:21
momentmaker added a commit that referenced this pull request Apr 9, 2024
* develop:
  Update Nix apple sdk usage (#12758)
  [KS-136] Update staging (#12703)
  update changelog path (#12757)
  Add support for dynamic pipeline runs with persistence (#12367)
  Fix nix mac issues building core missing newer apple sdk libs (#12746)
  Fix issues in package.json (#12748)
  [fix] Install jq when building plugins image (#12750)
  Automatic gas in load tests (#12416)
  remove VERSION file to use version from package.json (#12663)
  update package.json version (#12745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants