Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase finality depth for chains with 1 finality depth to 10 #12756

Merged
merged 42 commits into from
Jun 4, 2024
Merged

increase finality depth for chains with 1 finality depth to 10 #12756

merged 42 commits into from
Jun 4, 2024

Conversation

poopoothegorilla
Copy link
Contributor

During times of finality/block height issues we risk ourselves/our node operators getting out of sync and potentially taking down entire feeds or even products. Increasing block finality depth could give us breathing room in case more of these issues happen in the future.

@poopoothegorilla poopoothegorilla requested review from a team as code owners April 9, 2024 14:33
samsondav
samsondav previously approved these changes Apr 9, 2024
View reviewed changes
jmank88
jmank88 previously approved these changes Apr 10, 2024
View reviewed changes
reductionista
reductionista previously approved these changes Apr 10, 2024
View reviewed changes
@poopoothegorilla poopoothegorilla dismissed stale reviews from reductionista and jmank88 via ba4c770 April 11, 2024 21:01
@poopoothegorilla poopoothegorilla force-pushed the jtw/increase-instant-finality-depth branch from 7a32964 to ba4c770 Compare April 11, 2024 21:01
@poopoothegorilla poopoothegorilla changed the title increase finality depth for chains with 1 finality depth to 3 increase finality depth for chains with 1 finality depth to 10 Apr 11, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@samsondav samsondav added this pull request to the merge queue Jun 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2024
@dimriou dimriou added this pull request to the merge queue Jun 4, 2024
Merged via the queue into develop with commit 50870c3 Jun 4, 2024
108 checks passed
@dimriou dimriou deleted the jtw/increase-instant-finality-depth branch June 4, 2024 16:16
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silaslenihan silaslenihan silaslenihan left review comments

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@samsondav samsondav samsondav approved these changes

@jmank88 jmank88 jmank88 approved these changes

@reductionista reductionista reductionista left review comments

@dimriou dimriou Awaiting requested review from dimriou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@poopoothegorilla @jmank88 @reductionista @samsondav @silaslenihan @prashantkumar1982 @dimriou