Configurable Client Errors #12760
Merged
Configurable Client Errors #12760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
jmank88
reviewed
Apr 10, 2024
jmank88
reviewed
Apr 10, 2024
jmank88
reviewed
Apr 10, 2024
jmank88
reviewed
Apr 10, 2024
jmank88
reviewed
Apr 10, 2024
|
jmank88
approved these changes
Apr 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
prashantkumar1982
approved these changes
Apr 23, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled providing custom error regexes for EVM in configuration toml files.
The EVM client error regex strings are hard coded, requiring us to release new versions/hotfixes in response to changes and new discoveries, as well as slowing down testing iterations by requiring new builds.
The ability to override the built-in regexes via the standard configuration would speed up both of these processes, as well as offer new flexibility in terms of being able to override these values per-chain, which could be both safer and more efficient.