Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DSL for LogPoller #12793

Merged
merged 8 commits into from
May 16, 2024
Merged

Implement DSL for LogPoller #12793

merged 8 commits into from
May 16, 2024

Conversation

EasterTheBunny
Copy link
Contributor

This commit implements the query DSL within LogPoller by remapping comparer filters to
topic and word filters. A parser then creates an SQL statement from the remapped events
and queries the log poller database directly.

@EasterTheBunny EasterTheBunny changed the base branch from develop to chain-reader-event-querying2 April 11, 2024 23:33
@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from 3432012 to d6aa675 Compare April 12, 2024 16:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 12, 2024 •
edited
Loading

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from 7e81204 to 847e26f Compare April 12, 2024 18:40
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from 847e26f to ac43608 Compare April 15, 2024 15:17
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from ac43608 to d6fdb13 Compare April 15, 2024 17:48
@ilija42 ilija42 force-pushed the chain-reader-event-querying2 branch from 2a59e99 to 22ae19f Compare April 16, 2024 11:18
@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from 2559c27 to 2d14233 Compare April 16, 2024 16:24
@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from 2d14233 to 4bba5f9 Compare April 16, 2024 16:25
ilija42
ilija42 requested changes Apr 17, 2024
View reviewed changes
core/chains/evm/logpoller/expression.go Outdated Show resolved Hide resolved
core/chains/evm/logpoller/expression.go Outdated Show resolved Hide resolved
core/chains/evm/logpoller/expression.go Outdated Show resolved Hide resolved
core/chains/evm/logpoller/expression.go Outdated Show resolved Hide resolved
core/chains/evm/logpoller/expression.go Outdated Show resolved Hide resolved
@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from f69ff74 to b7b91d9 Compare April 17, 2024 23:44
@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from 0f1f98f to ec69292 Compare May 13, 2024 15:27
@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from 179ac48 to 197e35b Compare May 14, 2024 14:27
@EasterTheBunny EasterTheBunny requested a review from a team as a code owner May 14, 2024 14:33
@EasterTheBunny EasterTheBunny mentioned this pull request May 14, 2024
Merged
mateusz-sekara
mateusz-sekara previously approved these changes May 15, 2024
View reviewed changes
ilija42
ilija42 reviewed May 15, 2024
View reviewed changes
core/services/relay/evm/event_binding.go
@@ -121,7 +121,7 @@ func (e *eventBinding) QueryKey(ctx context.Context, filter query.KeyFilter, lim
}
remapped.Expressions = append(defaultExpressions, remapped.Expressions...)

logs, err := e.lp.FilteredLogs(ctx, remapped, limitAndSort)
logs, err := e.lp.FilteredLogs(ctx, remapped, limitAndSort, e.contractName+"-"+e.eventName)
Copy link
Contributor

@ilija42 ilija42 May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is enough from observability perspective. We can query for same event from same contract with different filters. We should either pass a queryName from QueryKey or somehow turn limitAndSort and filter into a string? Although to make it easier we can do this in a separate PR under a separate ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a separate PR would be best to iron out the rest of this detail.

@EasterTheBunny EasterTheBunny force-pushed the BCF-3144-query-key-pg-query branch from 39abe02 to 7d4d24a Compare May 15, 2024 14:56
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
84.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@EasterTheBunny EasterTheBunny enabled auto-merge May 15, 2024 15:19
@EasterTheBunny EasterTheBunny added this pull request to the merge queue May 16, 2024
Merged via the queue into develop with commit ecfab64 May 16, 2024
105 of 106 checks passed
@EasterTheBunny EasterTheBunny deleted the BCF-3144-query-key-pg-query branch May 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EasterTheBunny @mateusz-sekara @ilija42