Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create HeadPoller for Multi-Node #12871

Merged
merged 20 commits into from
Apr 26, 2024
Merged

Create HeadPoller for Multi-Node #12871

merged 20 commits into from
Apr 26, 2024

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Apr 17, 2024 •
edited
Loading

Create poller which will be used for multi-node

@DylanTinianov DylanTinianov self-assigned this Apr 17, 2024
@DylanTinianov DylanTinianov changed the title Create polling transformer Create Multi-Node Poller Apr 22, 2024
@DylanTinianov DylanTinianov changed the title Create Multi-Node Poller Create HeadPoller for Multi-Node Apr 22, 2024
dhaidashenko
dhaidashenko requested changes Apr 24, 2024
View reviewed changes
common/client/head_poller.go Outdated Show resolved Hide resolved
common/client/head_poller.go Outdated Show resolved Hide resolved
common/client/head_poller.go Outdated Show resolved Hide resolved
common/client/head_poller_test.go Outdated Show resolved Hide resolved
common/client/head_poller_test.go Outdated Show resolved Hide resolved
@DylanTinianov DylanTinianov marked this pull request as ready for review April 26, 2024 15:00
@DylanTinianov DylanTinianov requested a review from a team as a code owner April 26, 2024 15:00
dhaidashenko
dhaidashenko reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@dhaidashenko dhaidashenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Left two nit comments

common/client/poller.go Outdated Show resolved Hide resolved
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

prashantkumar1982
prashantkumar1982 reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, but this is a great PR, with very detailed unit-tests!

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Apr 26, 2024
Merged via the queue into develop with commit 7338448 Apr 26, 2024
105 checks passed
@prashantkumar1982 prashantkumar1982 deleted the BCI-3053-multinode-polling-transformer branch April 26, 2024 17:27
HenryNguyen5 added a commit that referenced this pull request Apr 27, 2024
@HenryNguyen5
Revert "Create HeadPoller for Multi-Node (#12871)"
540d54b 
This reverts commit 7338448.
This was referenced Apr 27, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@dhaidashenko dhaidashenko dhaidashenko approved these changes

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanTinianov @dhaidashenko @prashantkumar1982