Fix in mem ds cache err handling cherry pick #12920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…12595) * Add jfpc cache staleness alert to config and pass it into jfpc cache * Extract JuelsPerFeeCoinCache cfg into a separate struct, improve naming * Changeset * Update config validation test * Reduce changeset to minor
…cache (#12907) * Fix inMemoryDataSourceCache get() warn log formatting * Fix in mem ds cache updateCache() to save runs even if some ds failed * Improve in memory data source cache Observe() logs and error messages * Add changeset
krehermann
reviewed
Apr 22, 2024
| @@ -2189,7 +2190,8 @@ ds1_multiply [type=multiply times=1.23]; | |||
| ds1 -> ds1_parse -> ds1_multiply -> answer1; | |||
| answer1 [type=median index=0]; | |||
| """ | |||
| juelsPerFeeCoinCacheDuration = "30s" | |||
| [pluginConfig.juelsPerFeeCoinCache] | |||
There was a problem hiding this comment.
is this going to break existing specs? if not, why not - it seems like a parsing change
There was a problem hiding this comment.
We never distributed specs that have this set, default value is always used
ilija42
changed the title
* Bumping solana * Bumping the checksum for solana validator
|
krehermann
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.