Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator Forwarder Production Readiness #12983

Merged
merged 20 commits into from
May 2, 2024
Merged

Operator Forwarder Production Readiness #12983

merged 20 commits into from
May 2, 2024

Conversation

austinborn
Copy link
Collaborator

@austinborn austinborn commented Apr 25, 2024 •
edited
Loading

  • Add new tests to test suite
  • Update interface names AuthorizedReceiverInterface -> IAuthorizedReceiver and WithdrawalInterface -> IWithdrawal
  • Move all files out of dev/ folder
  • Update compiler files and gas snapshot

@austinborn austinborn requested a review from RensR as a code owner April 25, 2024 19:38
@austinborn austinborn requested a review from a team April 25, 2024 21:15
@austinborn austinborn changed the title Operatorforwarder/prod readiness Operator-Forwarder Production Readiness Apr 25, 2024
@austinborn austinborn enabled auto-merge April 25, 2024 22:33
RensR
RensR reviewed Apr 26, 2024
View reviewed changes
contracts/src/v0.8/operatorforwarder/test/Factory.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/FuzzOperator.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/FuzzOperator.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/FuzzOperator.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/FuzzOperator.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/operator.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/operator.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/operator.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/testhelpers/Deployer.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/operatorforwarder/test/testhelpers/Deployer.t.sol Outdated Show resolved Hide resolved
@alecgard
Copy link

alecgard commented Apr 26, 2024 •
edited
Loading

I don't think the OperatorForwarder foundry tests are currently being run on PR - we may need to add to https://github.com/smartcontractkit/chainlink/blob/develop/.github/workflows/solidity-foundry.yml#L34

@austinborn
Copy link
Collaborator Author

I don't think the OperatorForwarder foundry tests are currently being run on PR - we may need to add to https://github.com/smartcontractkit/chainlink/blob/develop/.github/workflows/solidity-foundry.yml#L34

Thanks for the note, adding in now

@austinborn austinborn requested review from a team as code owners May 1, 2024 14:00
@austinborn austinborn requested review from RensR and alecgard May 2, 2024 07:33
@austinborn austinborn changed the title Operator-Forwarder Production Readiness Operator Forwarder Production Readiness May 2, 2024
@austinborn austinborn disabled auto-merge May 2, 2024 07:48
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@austinborn austinborn added this pull request to the merge queue May 2, 2024
@austinborn austinborn removed this pull request from the merge queue due to a manual request May 2, 2024
@austinborn austinborn added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit 644f5f2 May 2, 2024
110 checks passed
@austinborn austinborn deleted the operatorforwarder/prod-readiness branch May 2, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecgard alecgard alecgard approved these changes

@RensR RensR RensR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austinborn @alecgard @RensR