add coverage for registrar and registry #12988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shileiwill
changed the title
shileiwill
changed the title
RyanRHall
reviewed
May 2, 2024
|
|
||
| uint256 startRegistrarBalance = usdToken18.balanceOf(address(registrar)); | ||
|
|
||
| // approve the upkeep |
There was a problem hiding this comment.
typo - "cancel the upkeep"
Comment on lines
59
to
63
| uint256 endRegistrarBalance = usdToken18.balanceOf(address(registrar)); | ||
| assertEq(startRegistrarBalance - amount, endRegistrarBalance); |
There was a problem hiding this comment.
can we also test that the $$ is sent back to the admin?
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More in AUTO-10143
registerUpkeep in registrar
Existing:
testLink_autoApproveOff_happy
testLink_autoApproveOn_happy
testUSDToken_autoApproveOff_happy
testUSDToken_autoApproveOn_happy
testNative_autoApproveOn_happy
testNative_autoApproveOff_msgValue0
testNative_autoApproveOff_msgValueNot0
testLink_autoApproveOff_revertOnDuplicateEntry
New:
testLink_revertOnInsufficientPayment
testLink_revertOnInvalidAdminAddress
testLink_revertOnInvalidBillingToken
approve in registrar
New:
testUSDToken_happy
cancel in registrar
New:
testUSDToken_happy
AddFunds in registry is very well convered, just updated the name:
testNative_msgValue0: this covers Native
testNative_msgValueNot0: this covers Native
test_RevertsWhen_NativePaymentDoesntMatchBillingToken
test_RevertsWhen_UpkeepDoesNotExist
test_RevertsWhen_UpkeepIsCanceled
test_anyoneCanAddFunds
test_movesFundFromCorrectToken: this covers LINK and USD
test_emitsAnEvent