chore/fix incorrect flakey tests #13021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HenryNguyen5
commented
Apr 28, 2024
HenryNguyen5
commented
- Add exit logs for go_core_tests
- Print each iteration of a flakey test execution
- DRY up env var usage to prevent typos
cedric-cordenier
previously approved these changes
Apr 29, 2024
jmank88
reviewed
Apr 29, 2024
jmank88
previously approved these changes
Apr 29, 2024
Co-authored-by: Jordan Krage <[email protected]>
HenryNguyen5
dismissed stale reviews from jmank88 and cedric-cordenier
via
22253c4
jmank88
approved these changes
Apr 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.