Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecateCapability #13036

Merged
merged 7 commits into from
Apr 30, 2024

Conversation

DeividasK
Copy link
Collaborator

No description provided.

…stry-get-capabilities

# Conflicts:
#	core/gethwrappers/keystone/generated/keystone_capability_registry/keystone_capability_registry.go
#	core/gethwrappers/keystone/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@DeividasK DeividasK marked this pull request as ready for review April 29, 2024 17:43
bolekk
bolekk previously approved these changes Apr 30, 2024
contracts/src/v0.8/keystone/CapabilityRegistry.sol Outdated Show resolved Hide resolved
@@ -0,0 +1,69 @@
// SPDX-License-Identifier: MIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: file name correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests deprecateCapability, so I'm following the convention of naming files with the function that is being tested.

Base automatically changed from KS-175-public-registry-get-capabilities to develop April 30, 2024 10:00
@DeividasK DeividasK dismissed bolekk’s stale review April 30, 2024 10:00

The base branch was changed.

…stry-curse-capability-version

# Conflicts:
#	contracts/src/v0.8/keystone/CapabilityRegistry.sol
#	core/gethwrappers/keystone/generated/keystone_capability_registry/keystone_capability_registry.go
#	core/gethwrappers/keystone/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@DeividasK DeividasK enabled auto-merge April 30, 2024 11:36
@DeividasK DeividasK added this pull request to the merge queue Apr 30, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit 77efb61 Apr 30, 2024
105 checks passed
@DeividasK DeividasK deleted the KS-125-public-registry-curse-capability-version branch April 30, 2024 12:08
davidcauchi pushed a commit that referenced this pull request May 6, 2024
* Add getCapabilities

* Fix comments

* Add deprecateCapability

* Wrappers + changesets

* Name fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants