Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KS-90] Add database-backed store #13045

Merged
merged 6 commits into from
May 6, 2024
Merged

[KS-90] Add database-backed store #13045

merged 6 commits into from
May 6, 2024

Conversation

cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Apr 30, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cedric-cordenier cedric-cordenier marked this pull request as ready for review April 30, 2024 19:22
@cedric-cordenier cedric-cordenier requested a review from a team as a code owner April 30, 2024 19:22
HenryNguyen5
HenryNguyen5 reviewed May 1, 2024
View reviewed changes
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
core/services/workflows/store_db.go Outdated Show resolved Hide resolved
HenryNguyen5
HenryNguyen5 suggested changes May 2, 2024
View reviewed changes
core/services/workflows/store/store.go Outdated Show resolved Hide resolved
core/services/workflows/store/store_db.go Outdated Show resolved Hide resolved
core/store/migrate/migrations/0235_add_workflow_models.sql Outdated Show resolved Hide resolved
core/store/migrate/migrations/0235_add_workflow_models.sql Show resolved Hide resolved
core/store/migrate/migrations/0235_add_workflow_models.sql Outdated Show resolved Hide resolved
core/store/migrate/migrations/0235_add_workflow_models.sql Outdated Show resolved Hide resolved
core/store/migrate/migrations/0235_add_workflow_models.sql Outdated Show resolved Hide resolved
core/store/migrate/migrations/0235_add_workflow_models.sql Show resolved Hide resolved
core/store/migrate/migrations/0235_add_workflow_models.sql Show resolved Hide resolved
bolekk
bolekk reviewed May 2, 2024
View reviewed changes
core/store/migrate/migrations/0235_add_workflow_models.sql Outdated Show resolved Hide resolved
core/services/workflows/engine.go Show resolved Hide resolved
core/services/workflows/engine.go Outdated Show resolved Hide resolved
core/services/workflows/store/store.go Outdated Show resolved Hide resolved
core/services/workflows/store/models.go Outdated Show resolved Hide resolved
core/services/workflows/engine.go Show resolved Hide resolved
core/services/workflows/store/store_db.go Show resolved Hide resolved
core/store/migrate/migrations/0235_add_workflow_models.sql Show resolved Hide resolved
@cedric-cordenier cedric-cordenier force-pushed the add-persistent-store branch 3 times, most recently from 80df01d to 390c15d Compare May 2, 2024 17:39
HenryNguyen5
HenryNguyen5 reviewed May 6, 2024
View reviewed changes
core/services/workflows/engine.go Outdated Show resolved Hide resolved
core/services/workflows/store/store_db.go Outdated Show resolved Hide resolved
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
11 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@cedric-cordenier cedric-cordenier added this pull request to the merge queue May 6, 2024
Merged via the queue into develop with commit 0955d46 May 6, 2024
104 of 105 checks passed
@cedric-cordenier cedric-cordenier deleted the add-persistent-store branch May 6, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenryNguyen5 HenryNguyen5 HenryNguyen5 approved these changes

@krehermann krehermann Awaiting requested review from krehermann

@ettec ettec Awaiting requested review from ettec

@bolekk bolekk Awaiting requested review from bolekk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedric-cordenier @bolekk @HenryNguyen5