Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bci 2996 local finality violation #13048

Merged
merged 72 commits into from
Jun 28, 2024

Conversation

dhaidashenko
Copy link
Collaborator

@dhaidashenko dhaidashenko commented Apr 30, 2024

Implementation of Local Finality Violation CLIP.

To reduce scope of the PR following temporary workarounds were made:

  • HeadTrackers function to get the latest finalized block performs RPC requests. It's planned to use a cached chain constructed from the latest block received via subscription. Unfortunately such implementation lead to large number of OCR/OCR2 test failures. We plan to address it but in separate PR. Ticket
  • Tests, except integration, that require LogPoller to use SimiulatedHeadTracker - a simplified version that is easier to create and write tests with. We plan to switch to full implementation. Ticket

…ion if we are communicating with RPC with highest finalized block
reductionista
reductionista previously approved these changes Jun 26, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
Copy link
Contributor

@amit-momin amit-momin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the code but approving to help unblock while experiencing permission issues

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Jun 28, 2024
Merged via the queue into develop with commit 3f8c00a Jun 28, 2024
113 checks passed
@prashantkumar1982 prashantkumar1982 deleted the feature/BCI-2996-local-finality-violation branch June 28, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants