-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bci 2996 local finality violation #13048
Merged
prashantkumar1982
merged 72 commits into
develop
from
feature/BCI-2996-local-finality-violation
Jun 28, 2024
Merged
Feature/bci 2996 local finality violation #13048
prashantkumar1982
merged 72 commits into
develop
from
feature/BCI-2996-local-finality-violation
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/chains/evm/client/rpc_client.go
# Conflicts: # core/chains/evm/client/sub_error_wrapper_test.go # core/chains/evm/headtracker/heads_test.go
…ion if we are communicating with RPC with highest finalized block
…ialHead processing and subscription
prashantkumar1982
previously approved these changes
Jun 26, 2024
reductionista
previously approved these changes
Jun 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 27, 2024
dhaidashenko
dismissed stale reviews from reductionista and prashantkumar1982
via
June 27, 2024 17:14
992aeb4
reductionista
approved these changes
Jun 27, 2024
Quality Gate passedIssues Measures |
prashantkumar1982
approved these changes
Jun 28, 2024
amit-momin
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the code but approving to help unblock while experiencing permission issues
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Local Finality Violation CLIP.
To reduce scope of the PR following temporary workarounds were made: