-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogen solidity wrappers #13062
Autogen solidity wrappers #13062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 this is great! I don't understand all the infra-related env vars and their usage, so you probably still want someone from releng/tooling to take a look, but I approve the CI/GHA setup. One thing to potentially inspect is whether this works on conflicts with base. Currently, I am manually resolving them.
+1 this is awesome! We were exploring a different approach using pre-push hooks to automate this (in a ccip proposal), but if this works well in CI that's even better :) What do you think about also adding gas snapshot generation in the same way as for the wrappers? |
3072e97
to
84fe901
Compare
Definitely, the ideal goal is that we can use this for anything that can be auto generated, since those are toil tasks that we shouldn't have to worry about. I wanted to get a small use case working well first, then we can expand upon it |
What do you mean "conflicts with base"? This action directly commits back to the PR branch. I'm not sure how it would generate conflicts that would cause the action to fail. Unless you mean the case where your solidity changes create conflicts against trunk. In this case, I think the only thing we'd have to do (which you do now locally) is to perform a |
84fe901
to
183b65f
Compare
183b65f
to
1bf0ba2
Compare
Quality Gate passedIssues Measures |
Tested on #13008