Update finality depth check headtracker #13089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silas Lenihan <[email protected]>
silaslenihan
force-pushed
the
BCI-2919-Update-FinalityDepth-check-logic-on-Head-Tracker
branch
from
a6d7c2b to
fc9c081
Compare
silaslenihan
force-pushed
the
BCI-2919-Update-FinalityDepth-check-logic-on-Head-Tracker
branch
from
e60f5dc to
c20bfd0
Compare
dimriou
reviewed
May 8, 2024
common/headtracker/head_tracker.go
Outdated
| if head.BlockNumber() < prevUnFinalizedHead { | ||
| prevLatestFinalized := prevHead.LatestFinalizedHead() | ||
|
|
||
| if prevLatestFinalized != nil && prevLatestFinalized.IsValid() && head.BlockNumber() <= prevLatestFinalized.BlockNumber() { |
There was a problem hiding this comment.
It is already checking prevLatestFinalized.IsValid()
amit-momin
reviewed
May 8, 2024
amit-momin
previously approved these changes
May 8, 2024
dimriou
reviewed
May 20, 2024
silaslenihan
force-pushed
the
BCI-2919-Update-FinalityDepth-check-logic-on-Head-Tracker
branch
from
a953dcc to
216c11a
Compare
silaslenihan
force-pushed
the
BCI-2919-Update-FinalityDepth-check-logic-on-Head-Tracker
branch
from
87fe2ca to
e854293
Compare
dimriou
approved these changes
May 20, 2024
amit-momin
approved these changes
May 20, 2024
|
prashantkumar1982
approved these changes
May 20, 2024
prashantkumar1982
deleted the
BCI-2919-Update-FinalityDepth-check-logic-on-Head-Tracker
branch
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update finality check in HeadTracker to use chain specific
LatestFinalizedHeadRelevant ticket: BCI-2919