[KS-186] Add custom OCR3 Capability Provider #13137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
force-pushed
the
KS-186-custom-provider
branch
5 times, most recently
from
6e77e80 to
337ec4a
Compare
cedric-cordenier
force-pushed
the
KS-186-custom-provider
branch
2 times, most recently
from
4826018 to
ea51eda
Compare
|
I see you updated files related to
|
cedric-cordenier
force-pushed
the
KS-186-custom-provider
branch
from
ea51eda to
aeb1fc8
Compare
cedric-cordenier
force-pushed
the
KS-186-custom-provider
branch
from
aeb1fc8 to
40fe574
Compare
krehermann
reviewed
May 8, 2024
krehermann
reviewed
May 8, 2024
| CSAETHKeystore: keyStore, | ||
| DS: db, | ||
| CSAETHKeystore: keyStore, | ||
| CapabilitiesRegistry: capabilities.NewRegistry(lggr), |
There was a problem hiding this comment.
there does not seem to be any test for the new feature. what's going on?
There was a problem hiding this comment.
technically this is testing the new check " c.CapabilitiesRegistry == nil " ;)
There was a problem hiding this comment.
@krehermann I've added some validation tests, which covers the case. I won't add tests to the custom provider implementation because when I started to I ended up mocking everything under the moon so I didn't feel like the test would add any value. Lmk if that works
cedric-cordenier
force-pushed
the
KS-186-custom-provider
branch
from
0653f52 to
c9cf5b5
Compare
cedric-cordenier
force-pushed
the
KS-186-custom-provider
branch
from
c9cf5b5 to
4fc9b21
Compare
|
krehermann
approved these changes
May 9, 2024
bolekk
approved these changes
May 9, 2024
akuzni2
pushed a commit
that referenced
this pull request
May 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 11, 2024
* Fix metric description on mercury_transmit_queue_load * Add changeset * Add changesets tag * Decouple gas tests (#12972) * Add first version of evm utils * Remove unused context util * Add WSServer tests * Add NewLegacyTransaction test * Update NewTestChainScopedConfig to apply correct defaults * Decouple gas package tests from core * Move testutils * Update paths * Fix import error * Add changeset * Add logs to identify when assumptions of log queuing behaviour are violated (#12846) * Add logs to identify when assumptions of log queuing behaviour are violated * Add tests * go import * Add changeset * Update enqueuing assumption * Update tests * Extract block tracking into a separate function * Clean up outdated enqueued blocks * Clean up imports * Ignore reord buffer in cleanup * Cleanup test name * tools/docker: bump postgres to v14 (#13156) * changed spammy error log to debug (#13153) * [KS-186] Add custom OCR3 Capability Provider (#13137) * [KS-193] Pass MercuryTriggerService to Mercury Transmitter (#13118) 1. Add EnableTriggerCapability flag to Relay config 2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider() 3. Make it available in the Transmitter (no-op for now) * update changeset to include db_update tag (#13170) * fix go-etheruem compatibility pipeline trigger (#13162) * Revert "Add logs to identify when assumptions of log queuing behaviour are violated" (#13173) * Revert "Add logs to identify when assumptions of log queuing behaviour are vi…" This reverts commit 6a342ae. * Add changeset * chore: update solana-build-contracts for node20 (#13175) * chore: update solana-build-contracts for node20 * chore: bump chainlink-solana version * Decouple utils tests from core (#12993) * Add first version of evm utils * Remove unused context util * Add WSServer tests * Add NewLegacyTransaction test * Update NewTestChainScopedConfig to apply correct defaults * Move testutils * Decouple utils tests from core * Add changeset --------- Co-authored-by: Dimitris Grigoriou <[email protected]> Co-authored-by: ferglor <[email protected]> Co-authored-by: Jordan Krage <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: Cedric <[email protected]> Co-authored-by: Bolek <[email protected]> Co-authored-by: Chunkai Yang <[email protected]> Co-authored-by: Bartek Tofel <[email protected]> Co-authored-by: Erik Burton <[email protected]>
augustbleeds
pushed a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.