Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockery: re-gen stale mocks; rm unused #13138

Merged
merged 1 commit into from
May 13, 2024
Merged

mockery: re-gen stale mocks; rm unused #13138

merged 1 commit into from
May 13, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented May 8, 2024

We had three stale mocks without corresponding go:generate statements. One was unused and has been removed. The other two have had go:generate statements added.

As a follow-up to prevent this from happening: Our CI process does not see these as problematic, since they are committed and do not produce a diff. We could add a step before make generate that removes all the generated mockery files to ensure that one which do not get re-generated produce a diff that fails CI.

@jmank88 jmank88 requested review from a team as code owners May 8, 2024 11:45
Copy link
Contributor

github-actions bot commented May 8, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production
Copy link

@jmank88 jmank88 enabled auto-merge May 8, 2024 12:30
@jmank88 jmank88 requested a review from HenryNguyen5 May 13, 2024 13:37
@jmank88 jmank88 requested a review from a team May 13, 2024 20:46
@jmank88 jmank88 added this pull request to the merge queue May 13, 2024
Merged via the queue into develop with commit 68a742f May 13, 2024
106 of 107 checks passed
@jmank88 jmank88 deleted the stale-mocks branch May 13, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants