Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed spammy error log to debug #13160

Merged
merged 1 commit into from
May 9, 2024
+3 −7
Merged

changed spammy error log to debug #13160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions core/services/pipeline/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,18 +457,14 @@ func (r *runner) run(ctx context.Context, pipeline *Pipeline, run *Run, vars Var
"run.Inputs", run.Inputs,
)
}
if run.HasFatalErrors() {
l = l.With("run.FatalErrors", run.FatalErrors)
}
if run.HasErrors() {
l = l.With("run.AllErrors", run.AllErrors)
}
l = l.With("run.State", run.State, "fatal", run.HasFatalErrors(), "runTime", runTime)
if run.HasFatalErrors() {
// This will also log at error level in OCR if it fails Observe so the
// level is appropriate
l.Errorw("Completed pipeline run with fatal errors")
l = l.With("run.FatalErrors", run.FatalErrors)
l.Debugw("Completed pipeline run with fatal errors")
} else if run.HasErrors() {
l = l.With("run.AllErrors", run.AllErrors)
l.Debugw("Completed pipeline run with errors")
} else {
l.Debugw("Completed pipeline run successfully")
Expand Down
Loading