improve test timeout in automation smoke tests #13182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anirudhwarrier
changed the title
vla33
approved these changes
May 13, 2024
anirudhwarrier
commented
May 13, 2024
| @@ -189,7 +189,7 @@ func SetupAutomationBasic(t *testing.T, nodeUpgrade bool) { | |||
| g.Expect(counter.Int64()).Should(gomega.BeNumerically(">=", int64(expect)), | |||
| "Expected consumer counter to be greater than %d, but got %d", expect, counter.Int64()) | |||
| } | |||
| }, "10m", "1s").Should(gomega.Succeed()) // ~1m for cluster setup, ~2m for performing each upkeep 5 times, ~2m buffer | |||
| }, "5m", "1s").Should(gomega.Succeed()) // ~1m for cluster setup, ~2m for performing each upkeep 5 times, ~2m buffer | |||
There was a problem hiding this comment.
Not sure why this was bumped from 5 to 10 earlier. But 5 is more than enough.
anirudhwarrier
commented
May 13, 2024
| @@ -1238,7 +1238,7 @@ func TestSetOffchainConfigWithMaxGasPrice(t *testing.T) { | |||
| g.Expect(counter.Int64()).Should(gomega.BeNumerically(">", int64(0)), | |||
| "Expected consumer counter to be greater than 0, but got %d") | |||
| } | |||
| }, "2m", "5s").Should(gomega.Succeed()) // ~1m for cluster setup, ~1m for performing each upkeep once, ~2m buffer | |||
| }, "4m", "5s").Should(gomega.Succeed()) // ~1m for cluster setup, ~1m for performing each upkeep once, ~2m buffer | |||
There was a problem hiding this comment.
This test was flaky and failed multiple times at this step. Increasing wait period to 4m resolves this flake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing test timeout issues that was seen during #12688