Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed L1 fee estimation logic for L2s #13236

Closed
wants to merge 34 commits into from
Closed

Changed L1 fee estimation logic for L2s #13236

wants to merge 34 commits into from

Conversation

KuphJr
Copy link
Contributor

@KuphJr KuphJr commented May 16, 2024

To simplify the review, please use https://www.diffchecker.com/ to check the difference between the following files:

  • /v1_1_0/libraries/ChainSpecificUtil.sol vs /v1_3_1/libraries/ChainSpecificUtil.sol diff
  • /v1_3_0/interfaces/IFunctionsBilling.sol vs /v1_3_1/interfaces/IFunctionsBilling.sol diff
  • /v1_3_0/FunctionsBilling.sol vs /v1_3_1/FunctionsBilling.sol diff
  • /v1_3_0/FunctionsCoordinator.sol vs /v1_3_1/FunctionsCoordinator..sol diff

Also, check diff between /dev/v1_X and /v1_3_1`

Tofel and others added 16 commits May 20, 2024 11:35
* add support for median plugin in OCR2 tests

* add support for median plugin in OCR2 tests

* scan CL node logs to check whether plugins were activated

* use tagged CTF version
* use latest Seth

* move test config to CTF

* use latest CTF that fixes eth2 genesis generation

* use latest Seth

* use tagged CTF version

* WIP#1

* WIP#2

* add automation-specifc node configuration to TOML

* add node TOML config for OCR forwarders smoke tests

* add CL node TOML configuration for keeper tests

* add CL node TOML config for log poller

* add OCR1/2 TOML config

* add VRF* CL node TOML config

* remove functional options for setting CL node config in tests, use TOML instead

* go mod tidy

* fix go mod

* fix test env builder

* increase node funding in runlog test

* increase vrf node funding

* add on-demand keeper smoke tests workflow

* run keeper smoke tests once

* fix int tests yaml?

* [TT-922, TT-943] Migrate automation and log poller tests to Seth (#12688)

* WIP#1

* fix load test

* lints

* lints again

* uncomment tests

* fix logtrigger mercury test

* set privilege before starting consumer

* WIP#2

* WIP#2 - with high concurrency upkeep registration fails

* more or less working

* WIP#4

* small fixes

* fix lints

* use latest Seth

* Migrated keeper benchmark, kind of

* migrate keeper smoke tests

* bunch of optimisation

* migrate automation chaos test

* migrate log poller tests to Seth

* use anysynced key with log poller

* fix some of failing smoke tests

* fix go mod

* use correct Seth version

* better automation some test structure

* better automation some test structure

* go mod

* fix issues with missing LINK funds

* fix keeper test

* fix automation test

* clean up, comments, migrate keeper benchmark test

* mend

* use latest Seth

* cleanups, comments, etc

* clean ups, automation tests + keeper tests now always test multiple contracts

* use newer action version

* debug results when upkeeps fails

* run automation tests with post-failure debug

* run automation tests with post-failure debug

* better staleness report

* more debug for basic automation tests

* more assertions

* try with sleep

* increase performance check timeout to 3m

* separate config from consumer start

* more debug for performance chcek

* try with just 1 contract

* one more clean up

* run keeper tests in CI to test them

* solve automation load test registration failures

* subscribe to headers in benchmark test to observe upkeeps

* centralised ephemeral keys on testnet check, fixed keeper smoke tests, added root key buffer check

* do not fail, when on testnet and ephemeral keys are !=0, set them 0 instead

* don't fail in test config, display warning if eph addresses are set and set them to 0

* fix possible nil pointer, remove block range timeout, mutex for error appending

* update seth version

* use buffered channel to read subscription headers from EVM node

* benchmark test increase RR mem and set DEBUG log level

* use CTF's concurrent executor to deploy contracts in parallel

* change architecture so that we have only 1 subscription and then we fan out the header to all goroutines; use SafeEVMHeader

* benchmark test increase geth disk and gaslimit

* decrease log level, latest seth and ctf

* update CTF dependency

* use concurrent executor in automation load test

* remove local replace

* add header subscription reconnect handling

* print return funds error

* limit automation load test deployment concurrency

* latest Seth + fix gun

* do not run keeper smoke tests on each commit anymore

* add one more error message

* use tagged CTF

* use latest Seth

* use latest Seth

* fix go.mod

* forget about smart reconnect, just do it in a loop

* use latest Seth

* check if context has error before executing any of contract calling wrapper functions

* prettify code + latest Seth

* update Seth

* optional retrying of read-only contract calls; used only by keeper benchmark test

* update Seth, estimate gas for funds sending

* fix new automation test, update Seth to v1.0.7

* increase timeout

* fix max price smoke test

* fix CreateOCRKeeperJobs for v2.0

* remove resolved TODO

* code review changes

* code review changes

* code review changes vol 2

* use CTF release version

* bump mod version

---------

Co-authored-by: anirudhwarrier <[email protected]>

* fix issue introduced by merge conflict

* adjust keeper & automation TOML configs

* restore old integration-tests workflow that doesn't run keeper tests

* fix double log stream shutdown

* add back clNodeOpts

* use tagged CTF version

---------

Co-authored-by: Ilja Pavlovs <[email protected]>
Co-authored-by: anirudhwarrier <[email protected]>
* Added Base Sepolia to ChainUtils

* Added tags to changeset files
… core ci (#13250)

* Bump gotestloghelper version via common actions bump and in core

* bump in make file as well
* Add docs for setting node config in E2E tests

* Apply PR comments
…13197)

* VRF-1066: VRF e2e tests - parametrize waiting for 256 block timeout

* VRF-1066: minor changes
* save test summary & flush logs if log scanner detects failing logs; fix attaching log stream to evm nodes

* fail in CI due to log scan

* display error log only once, do not fail on purpose

* use tagged CTF
This was broken at some point and this fixes it
* Update finality depth check headtracker

Signed-off-by: Silas Lenihan <[email protected]>

* added check for nil prevLatestFinalized

* added changeset

* updated changeset

* cleaned up nil protection in LatestFinalizedHead

* Added error tuple to LatestFinalizedHead

* Added error tuple to LatestFinalizedHead

* removed error from LatestFinalizedHead

---------

Signed-off-by: Silas Lenihan <[email protected]>
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@KuphJr
Copy link
Contributor Author

KuphJr commented May 23, 2024

Closed in favor of this: #13268

@KuphJr KuphJr closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants