core/chains/evm/config/toml/defaults: remove ineffectual overrides #13243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
dimriou
reviewed
May 17, 2024
jmank88
force-pushed
the
ineffectual-overrides
branch
from
bca24a2 to
707d483
Compare
jmank88
force-pushed
the
ineffectual-overrides
branch
from
707d483 to
97e6684
Compare
jmank88
force-pushed
the
ineffectual-overrides
branch
from
97e6684 to
34dc810
Compare
jmank88
force-pushed
the
ineffectual-overrides
branch
from
34dc810 to
ce235c3
Compare
dhaidashenko
approved these changes
May 17, 2024
dimriou
approved these changes
May 17, 2024
samsondav
approved these changes
May 17, 2024
| @@ -2,32 +2,19 @@ | |||
| # Clique offers finality within (N/2)+1 blocks where N is number of signers | |||
| # There are 21 BSC validators so theoretically finality should occur after 21/2+1 = 11 blocks | |||
| ChainID = '56' | |||
| # Keeping this >> 11 because it's not expensive and gives us a safety margin | |||
There was a problem hiding this comment.
Maybe this comment ought to remain, to show why we chose to go with eth's depth for BSC too?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes removing redundant/ineffectual overrides from the evm configs. I left a few behind which had long comments about lack of support, so that we don't accidentally change them.