Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved L1->L2 fee calculation logic for Functions #13268

Closed
wants to merge 3 commits into from
Closed

Improved L1->L2 fee calculation logic for Functions #13268

wants to merge 3 commits into from

Conversation

KuphJr
Copy link
Contributor

@KuphJr KuphJr commented May 21, 2024 •
edited
Loading

  • Updates L1 fee calculation logic for Arbitrum to use correct calldata size
  • Update L1 fee calculation logic for Optimism / Base to use new GasPriceOracle.getL1FeeUpperBound(calldataSize) function introduced in the Fjord hardfork

@KuphJr KuphJr requested review from a team and RensR as code owners May 21, 2024 01:47
@KuphJr KuphJr requested a review from justinkaseman May 21, 2024 14:45
FelixFan1992
FelixFan1992 previously approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@FelixFan1992 FelixFan1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@KuphJr KuphJr enabled auto-merge June 4, 2024 18:22
@KuphJr KuphJr requested review from ibrajer and roberto-bayardo June 4, 2024 18:25
justinkaseman
justinkaseman previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@justinkaseman justinkaseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, pending staging sniff tests should be done before merging.

@KuphJr KuphJr disabled auto-merge June 12, 2024 22:54
@KuphJr KuphJr force-pushed the FUN-1340-L1-L2-fee-improvements branch from 35c2d80 to 49c119b Compare June 12, 2024 23:10
@KuphJr KuphJr requested a review from justinkaseman June 13, 2024 14:06
@KuphJr
Copy link
Contributor Author

KuphJr commented Jul 12, 2024

Changes were ported over to this PR: #13815

@KuphJr KuphJr closed this Jul 12, 2024
@KuphJr KuphJr deleted the FUN-1340-L1-L2-fee-improvements branch July 12, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkaseman justinkaseman justinkaseman approved these changes

@RensR RensR Awaiting requested review from RensR

@RyanRHall RyanRHall Awaiting requested review from RyanRHall

@jinhoonbang jinhoonbang Awaiting requested review from jinhoonbang

@matYang matYang Awaiting requested review from matYang

@FelixFan1992 FelixFan1992 Awaiting requested review from FelixFan1992

@ibrajer ibrajer Awaiting requested review from ibrajer

@roberto-bayardo roberto-bayardo Awaiting requested review from roberto-bayardo

@archseer archseer Awaiting requested review from archseer

@bolekk bolekk Awaiting requested review from bolekk

@patrick-dowell patrick-dowell Awaiting requested review from patrick-dowell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KuphJr @matYang @ibrajer @roberto-bayardo @FelixFan1992 @justinkaseman