Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relayer ContractReader( chain reader) constructor #13274

Merged
merged 4 commits into from
May 27, 2024
Merged

Relayer ContractReader( chain reader) constructor #13274

merged 4 commits into from
May 27, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented May 21, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@ilija42 ilija42 force-pushed the relayer-chainreader branch 2 times, most recently from f38a80e to 8dccb95 Compare May 21, 2024 23:07
@ilija42 ilija42 force-pushed the relayer-chainreader branch from 8dccb95 to 74265e9 Compare May 22, 2024 11:28
@ilija42 ilija42 force-pushed the relayer-chainreader branch from 74265e9 to df6ea9c Compare May 22, 2024 12:08
@ilija42 ilija42 force-pushed the relayer-chainreader branch from df6ea9c to f8f9ac3 Compare May 22, 2024 12:11
@ilija42 ilija42 force-pushed the relayer-chainreader branch from f8f9ac3 to 92c6f27 Compare May 22, 2024 12:34
@ilija42 ilija42 force-pushed the relayer-chainreader branch from 92c6f27 to 36397c8 Compare May 22, 2024 13:02
@ilija42 ilija42 force-pushed the relayer-chainreader branch from 36397c8 to 34c7e02 Compare May 22, 2024 13:51
@ilija42 ilija42 force-pushed the relayer-chainreader branch from bebec9a to b923b75 Compare May 22, 2024 16:28
@ilija42 ilija42 force-pushed the relayer-chainreader branch from b923b75 to 59ba5b0 Compare May 22, 2024 16:54
@ilija42 ilija42 force-pushed the relayer-chainreader branch from 59ba5b0 to 2bc09fd Compare May 22, 2024 17:08
@ilija42 ilija42 force-pushed the relayer-chainreader branch from 2bc09fd to 47a33f4 Compare May 23, 2024 14:32
@ilija42 ilija42 marked this pull request as ready for review May 23, 2024 14:32
@ilija42 ilija42 requested review from a team as code owners May 23, 2024 14:32
ilija42
ilija42 commented May 23, 2024
View reviewed changes
Copy link
Contributor Author

@ilija42 ilija42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing core test and Solana integration test will be fixed by an incoming PR that is being reviewed unrelated to this

@ilija42 ilija42 force-pushed the relayer-chainreader branch from 25e33a8 to efc810b Compare May 24, 2024 10:14
@ilija42
Merge remote-tracking branch 'origin/develop' into relayer-chainreader
8661890 
# Conflicts:
#	core/scripts/go.mod
#	core/scripts/go.sum
#	go.mod
#	go.sum
#	integration-tests/go.mod
#	integration-tests/go.sum
#	integration-tests/load/go.mod
#	integration-tests/load/go.sum
@ilija42 ilija42 force-pushed the relayer-chainreader branch from 327963d to 5675a58 Compare May 24, 2024 16:05
@ilija42 ilija42 force-pushed the relayer-chainreader branch from 7a51959 to ef2013a Compare May 24, 2024 20:53
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ilija42 ilija42 requested a review from george-dorin May 27, 2024 07:33
@ilija42 ilija42 enabled auto-merge May 27, 2024 07:33
@ilija42 ilija42 added this pull request to the merge queue May 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 27, 2024
@DeividasK DeividasK added this pull request to the merge queue May 27, 2024
Merged via the queue into develop with commit 9b8e252 May 27, 2024
106 of 107 checks passed
@DeividasK DeividasK deleted the relayer-chainreader branch May 27, 2024 10:22
augustbleeds pushed a commit that referenced this pull request Jun 14, 2024
@ilija42 @augustbleeds
Relayer ContractReader( chain reader) constructor (#13274)
20f2ab6 
* Implement NewChainReader method for evm Relayer

* Update relayer refs

* Update relayer refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeividasK DeividasK DeividasK approved these changes

@archseer archseer archseer approved these changes

@jmank88 jmank88 Awaiting requested review from jmank88

@george-dorin george-dorin Awaiting requested review from george-dorin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilija42 @jmank88 @archseer @DeividasK