fix decimals in corner cases and use round up #13287

shileiwill · 2024-05-22T04:52:19Z

This PR is to improve 2 things on payment:

Ensure to use the right decimal scaling in 2 corner cases (balance < gasCharge and balance < gasCharge + premium)
Round it up when we charge. Keep the default round down for NOPs payment. This ensures we get a minimum (1) charge for gas and premium.

Here is a good example of Rounding Errors, text search "Rounding Errors" in the article.

Went through the code paths again. decimal scaling is only in transmit path: more specifically they are in calculatePayment and handlePayment. handlePayment is to handle the 2 special cases which we missed before.

RyanRHall · 2024-05-23T17:45:37Z

contracts/src/v0.8/automation/dev/v2_3/AutomationRegistryBase2_3.sol

@@ -44,8 +44,8 @@ abstract contract AutomationRegistryBase2_3 is ConfirmedOwner {
  // Next block of constants are only used in maxPayment estimation during checkUpkeep simulation
  // These values are calibrated using hardhat tests which simulate various cases and verify that
  // the variables result in accurate estimation
-  uint256 internal constant REGISTRY_CONDITIONAL_OVERHEAD = 97_700; // Fixed gas overhead for conditional upkeeps
-  uint256 internal constant REGISTRY_LOG_OVERHEAD = 122_000; // Fixed gas overhead for log upkeeps
+  uint256 internal constant REGISTRY_CONDITIONAL_OVERHEAD = 97_700 + 500; // Fixed gas overhead for conditional upkeeps


should we just increase the values here?

cl-sonarqube-production · 2024-05-28T22:30:38Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

shileiwill requested review from RyanRHall, FelixFan1992 and infiloop2 May 22, 2024 04:52

shileiwill requested a review from a team as a code owner May 22, 2024 04:52

shileiwill temporarily deployed to sdlc May 22, 2024 04:52 — with GitHub Actions Inactive

app-token-issuer-infra-releng bot requested a review from a team as a code owner May 22, 2024 04:57

app-token-issuer-infra-releng bot temporarily deployed to sdlc May 22, 2024 04:57 Inactive

shileiwill force-pushed the roundup branch from fde873e to c1e36ed Compare May 23, 2024 01:20

shileiwill temporarily deployed to sdlc May 23, 2024 01:20 — with GitHub Actions Inactive

RyanRHall previously approved these changes May 23, 2024

View reviewed changes

shileiwill dismissed RyanRHall’s stale review via ffdf3fd May 23, 2024 23:47

shileiwill force-pushed the roundup branch from c1e36ed to ffdf3fd Compare May 23, 2024 23:47

shileiwill temporarily deployed to sdlc May 23, 2024 23:47 — with GitHub Actions Inactive

shileiwill temporarily deployed to sdlc May 24, 2024 20:29 — with GitHub Actions Inactive

fix decimals in corner cases and use round up

d32f070

shileiwill force-pushed the roundup branch from 75778d0 to d32f070 Compare May 25, 2024 05:20

shileiwill temporarily deployed to sdlc May 25, 2024 05:20 — with GitHub Actions Inactive

RyanRHall approved these changes May 28, 2024

View reviewed changes

FelixFan1992 approved these changes May 28, 2024

View reviewed changes

shileiwill added this pull request to the merge queue May 28, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024