Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BlockHistoryEstimator check to halt excessive bumping #13297

Merged
merged 11 commits into from
Jun 10, 2024
Merged

Refactor BlockHistoryEstimator check to halt excessive bumping #13297

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c82cce8
Refactored BlockHistoryEstimator check to halt excessive bumping
amit-momin May 22, 2024
b7076ae
Added changeset
amit-momin May 22, 2024
0a2c735
Fixed linting
amit-momin May 22, 2024
c9bea11
Addressed feedback
amit-momin May 24, 2024
bb48f58
Merge branch 'develop' into BCI-2883-Refactor-Block-History-Estimator…
amit-momin May 24, 2024
2959862
Merge branch 'develop' into BCI-2883-Refactor-Block-History-Estimator…
amit-momin May 28, 2024
d52b8fb
Reverted halt bumping check to prevent bumping on nil max gas price o…
amit-momin May 29, 2024
5a270ae
Updated comment
amit-momin May 29, 2024
6d8da25
Fixed test
amit-momin May 30, 2024
bc92433
Cleaned up gwei formatting
amit-momin May 31, 2024
45788fa
Merge branch 'develop' into BCI-2883-Refactor-Block-History-Estimator…
amit-momin May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/shiny-poems-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"chainlink": minor
---

#changed Refactored the BlockHistoryEstimator check to prevent excessively bumping transactions. Check no longer waits for CheckInclusionBlocks to pass before assessing an attempt.
#bugfix Fixed a bug that would use the oldest blocks in the cached history instead of the latest to perform gas estimations.
Loading
Loading