[BCI-3271] Initial refactor of Keystone Write Capability for ChainWriter #13299

patrick-dowell · 2024-05-22T21:43:58Z

This is the first step toward moving Keystone onto ChainWriter. I moved a lot of the static values into config and isolated the functionality that will go into the SubmitSignedTransaction() function on the ChainWriter.

…riter

jmank88 · 2024-05-23T19:59:25Z

core/services/chainlink/config_test.go

+		if got.EVM[c].ChainWriter.GasLimit == nil {
+			got.EVM[c].ChainWriter.GasLimit = ptr(uint64(200000))
+		}
+		if got.EVM[c].ChainWriter.Checker == nil {
+			checker := "simulate"
+			got.EVM[c].ChainWriter.Checker = &checker
+		}
+		if got.EVM[c].ChainWriter.ABI == nil {
+			abi := "[{\"inputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"constructor\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"signer\",\"type\":\"address\"}],\"name\":\"DuplicateSigner\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"numSigners\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"maxSigners\",\"type\":\"uint256\"}],\"name\":\"ExcessSigners\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"FaultToleranceMustBePositive\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"numSigners\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"minSigners\",\"type\":\"uint256\"}],\"name\":\"InsufficientSigners\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint32\",\"name\":\"donId\",\"type\":\"uint32\"}],\"name\":\"InvalidDonId\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"InvalidReport\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"bytes\",\"name\":\"signature\",\"type\":\"bytes\"}],\"name\":\"InvalidSignature\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"expected\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"received\",\"type\":\"uint256\"}],\"name\":\"InvalidSignatureCount\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"signer\",\"type\":\"address\"}],\"name\":\"InvalidSigner\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"ReentrantCall\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"bytes32\",\"name\":\"reportId\",\"type\":\"bytes32\"}],\"name\":\"ReportAlreadyProcessed\",\"type\":\"error\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"OwnershipTransferRequested\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"OwnershipTransferred\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"receiver\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"workflowOwner\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"bytes32\",\"name\":\"workflowExecutionId\",\"type\":\"bytes32\"},{\"indexed\":false,\"internalType\":\"bool\",\"name\":\"result\",\"type\":\"bool\"}],\"name\":\"ReportProcessed\",\"type\":\"event\"},{\"inputs\":[],\"name\":\"acceptOwnership\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"receiver\",\"type\":\"address\"},{\"internalType\":\"bytes32\",\"name\":\"workflowExecutionId\",\"type\":\"bytes32\"}],\"name\":\"getTransmitter\",\"outputs\":[{\"internalType\":\"address\",\"name\":\"\",\"type\":\"address\"}],\"stateMutability\":\"view\",\"type\":\"function\"},{\"inputs\":[],\"name\":\"owner\",\"outputs\":[{\"internalType\":\"address\",\"name\":\"\",\"type\":\"address\"}],\"stateMutability\":\"view\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"receiverAddress\",\"type\":\"address\"},{\"internalType\":\"bytes\",\"name\":\"rawReport\",\"type\":\"bytes\"},{\"internalType\":\"bytes[]\",\"name\":\"signatures\",\"type\":\"bytes[]\"}],\"name\":\"report\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"uint32\",\"name\":\"donId\",\"type\":\"uint32\"},{\"internalType\":\"uint8\",\"name\":\"f\",\"type\":\"uint8\"},{\"internalType\":\"address[]\",\"name\":\"signers\",\"type\":\"address[]\"}],\"name\":\"setConfig\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"transferOwnership\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[],\"name\":\"typeAndVersion\",\"outputs\":[{\"internalType\":\"string\",\"name\":\"\",\"type\":\"string\"}],\"stateMutability\":\"pure\",\"type\":\"function\"}]"
+			got.EVM[c].ChainWriter.ABI = &abi
+		}


Can't some/all of these be set from the toml input instead?

let me see if I can. That would preferable to doing it this way, for sure.

core/config/docs/docs_test.go

archseer · 2024-05-24T07:40:42Z

core/config/docs/chains-evm.toml

+# Checker determines which checks get performed before a transaction is broadcasted by the TXM
+Checker = "simulate"
+# ABI is the ABI for the keystone forwarder, to be used by ChainWriter for packing the payload to the TXM
+ABI = "[{\"inputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"constructor\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"signer\",\"type\":\"address\"}],\"name\":\"DuplicateSigner\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"numSigners\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"maxSigners\",\"type\":\"uint256\"}],\"name\":\"ExcessSigners\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"FaultToleranceMustBePositive\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"numSigners\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"minSigners\",\"type\":\"uint256\"}],\"name\":\"InsufficientSigners\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint32\",\"name\":\"donId\",\"type\":\"uint32\"}],\"name\":\"InvalidDonId\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"InvalidReport\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"bytes\",\"name\":\"signature\",\"type\":\"bytes\"}],\"name\":\"InvalidSignature\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"expected\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"received\",\"type\":\"uint256\"}],\"name\":\"InvalidSignatureCount\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"signer\",\"type\":\"address\"}],\"name\":\"InvalidSigner\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"ReentrantCall\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"bytes32\",\"name\":\"reportId\",\"type\":\"bytes32\"}],\"name\":\"ReportAlreadyProcessed\",\"type\":\"error\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"OwnershipTransferRequested\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"OwnershipTransferred\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"receiver\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"workflowOwner\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"bytes32\",\"name\":\"workflowExecutionId\",\"type\":\"bytes32\"},{\"indexed\":false,\"internalType\":\"bool\",\"name\":\"result\",\"type\":\"bool\"}],\"name\":\"ReportProcessed\",\"type\":\"event\"},{\"inputs\":[],\"name\":\"acceptOwnership\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"receiver\",\"type\":\"address\"},{\"internalType\":\"bytes32\",\"name\":\"workflowExecutionId\",\"type\":\"bytes32\"}],\"name\":\"getTransmitter\",\"outputs\":[{\"internalType\":\"address\",\"name\":\"\",\"type\":\"address\"}],\"stateMutability\":\"view\",\"type\":\"function\"},{\"inputs\":[],\"name\":\"owner\",\"outputs\":[{\"internalType\":\"address\",\"name\":\"\",\"type\":\"address\"}],\"stateMutability\":\"view\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"receiverAddress\",\"type\":\"address\"},{\"internalType\":\"bytes\",\"name\":\"rawReport\",\"type\":\"bytes\"},{\"internalType\":\"bytes[]\",\"name\":\"signatures\",\"type\":\"bytes[]\"}],\"name\":\"report\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"uint32\",\"name\":\"donId\",\"type\":\"uint32\"},{\"internalType\":\"uint8\",\"name\":\"f\",\"type\":\"uint8\"},{\"internalType\":\"address[]\",\"name\":\"signers\",\"type\":\"address[]\"}],\"name\":\"setConfig\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"transferOwnership\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[],\"name\":\"typeAndVersion\",\"outputs\":[{\"internalType\":\"string\",\"name\":\"\",\"type\":\"string\"}],\"stateMutability\":\"pure\",\"type\":\"function\"}]"


I'm not a huge fan of how this is a big JSON blob. Perhaps we could use selector parser to construct the ABI. e.g. ABI = "report(address receiverAddress, bytes calldata rawReport, bytes[] calldata signatures)". The field could be first attempted to parse as JSON then fall back to selector parser.

archseer · 2024-05-24T07:45:44Z

core/config/docs/chains-evm.toml

@@ -424,3 +424,9 @@ GasLimit = 5400000 # Default
 FromAddress = '0x2a3e23c6f242F5345320814aC8a1b4E58707D292' # Example
 # ForwarderAddress is the keystone forwarder contract address on chain.
 ForwarderAddress = '0x2a3e23c6f242F5345320814aC8a1b4E58707D292' # Example
+# GasLimit controls the gas limit to be used for transactions sent via ChainWriter


Let's rename the config section from EVM.ChainWriter to EVM.Workflow since the config is specific to the keystone workflows/keystone forwarder.

Sounds good!

This would technically be a breaking change. Need to be careful with compatibility

@jmank88 What would break if we changed it? Assuming I changed all the references from ChainWriter to Workflow?

I added this for the purposes of the original Keystone demo, the field isn't being used outside of the one staging cluster we have

That's good, but I wonder if we should add a formal way to document experimental config so that we don't leave a confusing historical trail.

ilija42 · 2024-05-24T12:59:11Z

core/config/docs/chains-evm.toml

+# Checker determines which checks get performed before a transaction is broadcasted by the TXM
+Checker = "simulate"
+# ABI is the ABI for the keystone forwarder, to be used by ChainWriter for packing the payload to the TXM
+ABI = "[{\"inputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"constructor\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"signer\",\"type\":\"address\"}],\"name\":\"DuplicateSigner\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"numSigners\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"maxSigners\",\"type\":\"uint256\"}],\"name\":\"ExcessSigners\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"FaultToleranceMustBePositive\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"numSigners\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"minSigners\",\"type\":\"uint256\"}],\"name\":\"InsufficientSigners\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint32\",\"name\":\"donId\",\"type\":\"uint32\"}],\"name\":\"InvalidDonId\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"InvalidReport\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"bytes\",\"name\":\"signature\",\"type\":\"bytes\"}],\"name\":\"InvalidSignature\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"expected\",\"type\":\"uint256\"},{\"internalType\":\"uint256\",\"name\":\"received\",\"type\":\"uint256\"}],\"name\":\"InvalidSignatureCount\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"signer\",\"type\":\"address\"}],\"name\":\"InvalidSigner\",\"type\":\"error\"},{\"inputs\":[],\"name\":\"ReentrantCall\",\"type\":\"error\"},{\"inputs\":[{\"internalType\":\"bytes32\",\"name\":\"reportId\",\"type\":\"bytes32\"}],\"name\":\"ReportAlreadyProcessed\",\"type\":\"error\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"OwnershipTransferRequested\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"OwnershipTransferred\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"internalType\":\"address\",\"name\":\"receiver\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"address\",\"name\":\"workflowOwner\",\"type\":\"address\"},{\"indexed\":true,\"internalType\":\"bytes32\",\"name\":\"workflowExecutionId\",\"type\":\"bytes32\"},{\"indexed\":false,\"internalType\":\"bool\",\"name\":\"result\",\"type\":\"bool\"}],\"name\":\"ReportProcessed\",\"type\":\"event\"},{\"inputs\":[],\"name\":\"acceptOwnership\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"receiver\",\"type\":\"address\"},{\"internalType\":\"bytes32\",\"name\":\"workflowExecutionId\",\"type\":\"bytes32\"}],\"name\":\"getTransmitter\",\"outputs\":[{\"internalType\":\"address\",\"name\":\"\",\"type\":\"address\"}],\"stateMutability\":\"view\",\"type\":\"function\"},{\"inputs\":[],\"name\":\"owner\",\"outputs\":[{\"internalType\":\"address\",\"name\":\"\",\"type\":\"address\"}],\"stateMutability\":\"view\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"receiverAddress\",\"type\":\"address\"},{\"internalType\":\"bytes\",\"name\":\"rawReport\",\"type\":\"bytes\"},{\"internalType\":\"bytes[]\",\"name\":\"signatures\",\"type\":\"bytes[]\"}],\"name\":\"report\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"uint32\",\"name\":\"donId\",\"type\":\"uint32\"},{\"internalType\":\"uint8\",\"name\":\"f\",\"type\":\"uint8\"},{\"internalType\":\"address[]\",\"name\":\"signers\",\"type\":\"address[]\"}],\"name\":\"setConfig\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[{\"internalType\":\"address\",\"name\":\"to\",\"type\":\"address\"}],\"name\":\"transferOwnership\",\"outputs\":[],\"stateMutability\":\"nonpayable\",\"type\":\"function\"},{\"inputs\":[],\"name\":\"typeAndVersion\",\"outputs\":[{\"internalType\":\"string\",\"name\":\"\",\"type\":\"string\"}],\"stateMutability\":\"pure\",\"type\":\"function\"}]"


Is the whole ABI used? There is no need to have method and event definitions that aren't being useed

That's fair. Technically I think this ABI was generated and then I just copied it to the config. I could pair it down to only what chainwriter needs, but if we ever update it, it'll probably be easier to just paste the whole thing vs someone figuring out the subset of it that's needed.

Have you seen my comment above? This should just be a single line with the function selector that's then parsed into the abi via selector parser. No need for a raw blob

I don't think I really understand what you mean, does function selector mean listing out functions to be used by Chain Writer? If you specified it like: ABI = "report(address receiverAddress, bytes calldata rawReport, bytes[] calldata signatures)", how does it turn into:

{\"inputs\":[ {\"internalType\":\"address\",\"name\":\"receiverAddress\",\"type\":\"address\"}, {\"internalType\":\"bytes\",\"name\":\"rawReport\",\"type\":\"bytes\"}, {\"internalType\":\"bytes[]\",\"name\":\"signatures\",\"type\":\"bytes[]\"}], \"name\":\"report\", \"outputs\":[], \"stateMutability\":\"nonpayable\", \"type\":\"function\"}

We have a selector parser module that turns a function selector into an ABI: https://github.com/smartcontractkit/chainlink/blob/develop/core/chains/evm/abi/selector_parser.go

Nice, didn't know that exists. Looks good to me

amit-momin · 2024-05-24T17:50:41Z

core/capabilities/targets/write_target.go

-	txMeta := &txmgr.TxMeta{
-		// FwdrDestAddress could also be set for better logging but it's used for various purposes around Operator Forwarders
-		WorkflowExecutionID: &request.Metadata.WorkflowExecutionID,
+func (cap *EvmWrite) submitSignedTransaction(ctx context.Context, chainWriterConfig config.ChainWriter, report []byte, signatures [][]byte, toAddress string, txMeta map[string]interface{}) error {


I think this is missing the transactionID field that needs to be used for the TxRequest IdempotencyKey

You are correct. I can generate one in the write capability or just leave it as optional. I think it makes sense to generate and log it. @bolekk

can it be optional? there's no UUID returned by the SubmitSignedTransaction function

@cfal technically we could make it optional. It's a question of whether we want ChainWriter to enforce products passing one in or not. For now, I'll make it optional and not have keystone pass it in, but I noticed a note about making this function idempotent, and this UUID could be used for that purpose.

silaslenihan · 2024-05-24T20:42:38Z

core/capabilities/targets/write_target.go

@@ -122,47 +116,81 @@ func (cap *EvmWrite) Execute(ctx context.Context, request capabilities.Capabilit

 	// TODO: validate encoded report is prefixed with workflowID and executionID that match the request meta

-	// construct forwarder payload
-	calldata, err := forwardABI.Pack("report", common.HexToAddress(reqConfig.Address), inputs.Report, inputs.Signatures)
+	txMeta := make(map[string]interface{}) // TODO: Consider just using the TxMeta struct here and pass it to submitTransaction


What is the reason for not using the TxMeta struct (or a simplified version of that struct)?

I need to update this PR accordingly.

archseer · 2024-05-27T06:16:35Z

core/capabilities/targets/write_target.go

-	txm := cap.chain.TxManager()
-
-	config := cap.chain.Config().EVM().ChainWriter()
-
 	reqConfig, err := parseConfig(request.Config)


There should be a way to pass config into ChainWriter. Under EVM it only contains the destination address, but on solana this could also specify additional metadata that needs to be passed through, e.g. additional accounts to include in the transaction

Probably best to do same thing that was done for Chain Reader link. Just add a top level Relayer constructor for Chain Writer.

I wish there was a way to provide local configuration though. The values we're setting are specific to keystone/workflows and could potentially be configured by nops to some extent. Having them tweak a toplevel config unrelated to workflows seems unergonomic

It should be able to give you a new instance while reusing the chain component so it wouldn't be tweaking anything that is unrelated, so essentially same evm client but different chain writer details.

…riter

archseer · 2024-05-28T07:32:56Z

I have a cleanup with breaking changes here: #13259

I'm open to taking over this PR and rolling it into mine.

github-actions · 2024-05-28T07:52:22Z

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

…riter

cl-sonarqube-production · 2024-05-28T13:45:20Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Adding the config for GasLimit

ce9d568

patrick-dowell temporarily deployed to sdlc May 22, 2024 21:44 — with GitHub Actions Inactive

patrick-dowell added 2 commits May 23, 2024 00:25

starting to test

1abf1d3

created config field for checker, modified tests to get them to pass

2fed377

patrick-dowell had a problem deploying to sdlc May 23, 2024 08:29 — with GitHub Actions Failure

moving ABI to config, cleaning things up

cbcf299

patrick-dowell temporarily deployed to sdlc May 23, 2024 19:28 — with GitHub Actions Inactive

patrick-dowell marked this pull request as ready for review May 23, 2024 19:30

patrick-dowell requested review from a team as code owners May 23, 2024 19:30

patrick-dowell assigned jmank88, archseer, bolekk, nickcorin and poopoothegorilla May 23, 2024

patrick-dowell changed the title ~~Initial refactor of Keystone Write Capability for ChainWriter~~ [BCI-3271] Initial refactor of Keystone Write Capability for ChainWriter May 23, 2024

Merge branch 'develop' into BCI-3271-refactor-write-capability-chainw…

2ae8633

…riter

patrick-dowell temporarily deployed to sdlc May 23, 2024 19:54 — with GitHub Actions Inactive

jmank88 reviewed May 23, 2024

View reviewed changes

core/config/docs/docs_test.go Outdated Show resolved Hide resolved

archseer reviewed May 24, 2024

View reviewed changes

ilija42 self-requested a review May 24, 2024 11:31

ilija42 reviewed May 24, 2024

View reviewed changes

amit-momin reviewed May 24, 2024

View reviewed changes

silaslenihan reviewed May 24, 2024

View reviewed changes

reductionista mentioned this pull request May 24, 2024

BCF-3244 Index only the fifth word to reduce the db size overhead #13315 #13327

Merged

archseer reviewed May 27, 2024

View reviewed changes

Merge branch 'develop' into BCI-3271-refactor-write-capability-chainw…

025bb16

…riter

patrick-dowell temporarily deployed to sdlc May 27, 2024 17:57 — with GitHub Actions Inactive

Merge branch 'develop' into BCI-3271-refactor-write-capability-chainw…

df74307

…riter

patrick-dowell temporarily deployed to sdlc May 28, 2024 07:05 — with GitHub Actions Inactive

responding to code review and cleaning up

360d4b3

patrick-dowell temporarily deployed to sdlc May 28, 2024 07:51 — with GitHub Actions Inactive

making TransactionUUID optional and adding ContractMethod config

ca88ea7

patrick-dowell temporarily deployed to sdlc May 28, 2024 08:28 — with GitHub Actions Inactive

fixing accidental revert in the code

356fbbb

patrick-dowell temporarily deployed to sdlc May 28, 2024 08:29 — with GitHub Actions Inactive

Merge branch 'develop' into BCI-3271-refactor-write-capability-chainw…

fa91fbb

…riter

silaslenihan temporarily deployed to sdlc May 28, 2024 13:35 — with GitHub Actions Inactive

patrick-dowell closed this Jun 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BCI-3271] Initial refactor of Keystone Write Capability for ChainWriter #13299

[BCI-3271] Initial refactor of Keystone Write Capability for ChainWriter #13299

patrick-dowell commented May 22, 2024 •

edited

Loading

jmank88 May 23, 2024

patrick-dowell May 23, 2024

archseer May 24, 2024

archseer May 24, 2024

patrick-dowell May 24, 2024

jmank88 May 25, 2024

patrick-dowell May 26, 2024

archseer May 27, 2024

jmank88 May 28, 2024

ilija42 May 24, 2024

patrick-dowell May 24, 2024

archseer May 27, 2024

ilija42 May 27, 2024 •

edited

Loading

archseer May 27, 2024

ilija42 May 27, 2024

amit-momin May 24, 2024

patrick-dowell May 24, 2024

cfal May 27, 2024

patrick-dowell May 28, 2024

silaslenihan May 24, 2024

patrick-dowell May 24, 2024

archseer May 27, 2024

ilija42 May 27, 2024

archseer May 27, 2024

ilija42 May 27, 2024

archseer commented May 28, 2024

github-actions bot commented May 28, 2024

cl-sonarqube-production bot commented May 28, 2024

[BCI-3271] Initial refactor of Keystone Write Capability for ChainWriter #13299

[BCI-3271] Initial refactor of Keystone Write Capability for ChainWriter #13299

Conversation

patrick-dowell commented May 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilija42 May 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

archseer commented May 28, 2024

github-actions bot commented May 28, 2024

cl-sonarqube-production bot commented May 28, 2024

Quality Gate failed

patrick-dowell commented May 22, 2024 •

edited

Loading

ilija42 May 27, 2024 •

edited

Loading