Update KeystoneForwarder contract and IReceiver #13301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeividasK
commented
May 23, 2024
|
|
||
| // f can never be 0, so this means the config doesn't actually exist | ||
| if (s_configs[donId].f == 0) revert InvalidDonId(donId); | ||
|
|
||
| bytes32 reportId = _reportId(receiverAddress, workflowExecutionId); |
There was a problem hiding this comment.
Removed some variables because of StackTooDeep error 😭
DeividasK
force-pushed
the
KS-241-finalize-report-name-idea-and-update-receiver-contract
branch
from
cecf02e to
2e32753
Compare
DeividasK
requested review from
archseer,
bolekk,
patrick-dowell and
a team
as code owners
|
archseer
reviewed
May 30, 2024
| bytes32 indexed workflowExecutionId, | ||
| bytes32 indexed reportName, |
There was a problem hiding this comment.
I'm worried about how much extra metadata we're passing through now and any potential size issues on Solana. Could report name just be a u8 type ID/discriminator? 255 different report types per workflow ought to be enough
There was a problem hiding this comment.
As discussed offline, we could use address (20 bytes) for owner and only 12 bytes for report name.
|
replaced by #13389 |
DeividasK
deleted the
KS-241-finalize-report-name-idea-and-update-receiver-contract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: