implement a short term zk overflow mitigation #13319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action-feature-in-TXM
…action-feature-in-TXM
…action-feature-in-TXM
…action-feature-in-TXM
FelixFan1992
changed the base branch from
develop
to
BCI-3055-Add-new-TXM-method-to-allow-products-to-query-transaction-status
…transaction-status' into zk-overflow-short-term
…transaction-status' into zk-overflow-short-term
|
I see you updated files related to
|
|
FelixFan1992
commented
May 29, 2024
| } | ||
|
|
||
| _, err = t.txm.CreateTransaction(ctx, txmgr.TxRequest{ | ||
| IdempotencyKey: keyPtr, |
There was a problem hiding this comment.
tx with the same idempotency key will not be sent again
1 key means 1 onchain tx
amit-momin
force-pushed
the
BCI-3055-Add-new-TXM-method-to-allow-products-to-query-transaction-status
branch
from
9f43854 to
26d8c4a
Compare
Base automatically changed from
BCI-3055-Add-new-TXM-method-to-allow-products-to-query-transaction-status
to
develop
June 19, 2024 16:38
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.