-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT-1205 Investigate and fix failing OCR2 tests in compatibility pipeline #13334
Merged
gheorghestrimtu
merged 12 commits into
develop
from
TT-1205-investigate-and-fix-failing-ocr-2-tests-in-compatibility-pipeline
May 28, 2024
Merged
TT-1205 Investigate and fix failing OCR2 tests in compatibility pipeline #13334
gheorghestrimtu
merged 12 commits into
develop
from
TT-1205-investigate-and-fix-failing-ocr-2-tests-in-compatibility-pipeline
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tests-in-compatibility-pipeline
Tofel
reviewed
May 28, 2024
…atibility-pipeline' of github.com:smartcontractkit/chainlink into TT-1205-investigate-and-fix-failing-ocr-2-tests-in-compatibility-pipeline
Tofel
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one!
lukaszcl
approved these changes
May 28, 2024
Quality Gate passedIssues Measures |
gheorghestrimtu
deleted the
TT-1205-investigate-and-fix-failing-ocr-2-tests-in-compatibility-pipeline
branch
May 28, 2024 10:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes failing OCR2 tests in compatibility pipeline.
Until this PR the pipeline was building a test binary and running the tests using this binary.
After this PR the pipeline switched to running tests like all integration-tests, without a binary and using just repo checkout.
This PR also adds loki logging to the pipeline.
succesful run: https://github.com/smartcontractkit/chainlink/actions/runs/9266649074/job/25491553198