Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Allow duplicate edges #13340

Merged
merged 2 commits into from
May 29, 2024
Merged

[chore] Allow duplicate edges #13340

merged 2 commits into from
May 29, 2024

Conversation

cedric-cordenier
Copy link
Contributor

No description provided.

@cedric-cordenier cedric-cordenier requested review from a team as code owners May 28, 2024 11:01
@cedric-cordenier cedric-cordenier requested a review from ettec May 28, 2024 12:01
ettec
ettec previously approved these changes May 28, 2024
View reviewed changes
krehermann
krehermann previously approved these changes May 28, 2024
View reviewed changes
@cedric-cordenier cedric-cordenier added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@bolekk
Copy link
Contributor

bolekk commented May 28, 2024

If you're making another update, please use latest common.

@cedric-cordenier cedric-cordenier dismissed stale reviews from ettec and krehermann via 22aa986 May 28, 2024 17:47
@cedric-cordenier cedric-cordenier force-pushed the allow-duplicate-edges branch from 22aa986 to 84167c4 Compare May 28, 2024 17:51
@cedric-cordenier cedric-cordenier force-pushed the allow-duplicate-edges branch from 84167c4 to 3ddca34 Compare May 28, 2024 17:51
@cedric-cordenier cedric-cordenier force-pushed the allow-duplicate-edges branch from 3ddca34 to f460cbf Compare May 29, 2024 10:47
@cedric-cordenier cedric-cordenier force-pushed the allow-duplicate-edges branch from f460cbf to 98fe72c Compare May 29, 2024 10:47
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@cedric-cordenier cedric-cordenier added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue May 29, 2024
Merged via the queue into develop with commit 67295da May 29, 2024
107 of 108 checks passed
@cedric-cordenier cedric-cordenier deleted the allow-duplicate-edges branch May 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ettec ettec ettec approved these changes

@krehermann krehermann krehermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cedric-cordenier @bolekk @krehermann @ettec