Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCF-3234 remove app shortcut #13353

Merged
merged 6 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update shortcut links.
  • Loading branch information
pavel-raykov committed May 29, 2024
commit b847f9e7d2f4628fb317d326b66cfecc20883df1
2 changes: 1 addition & 1 deletion .changeset/neat-zebras-fix.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"chainlink": patch
"chainlink": minor
---

Remove deprecated app.shortcut links
2 changes: 1 addition & 1 deletion contracts/test/v0.8/automation/CronUpkeep.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ describe('CronUpkeep', () => {
it('has a limited public ABI [ @skip-coverage ]', () => {
// Casting cron is necessary due to a tricky versioning mismatch issue, likely between ethers
// and typechain. Remove once the version issue is resolved.
// https://app.shortcut.com/chainlinklabs/story/21905/remove-contract-cast-in-cronupkeep-test-ts
// https://smartcontract-it.atlassian.net/browse/ARCHIVE-22094
h.publicAbi(cron as unknown as Contract, [
's_maxJobs',
'performUpkeep',
Expand Down
2 changes: 1 addition & 1 deletion core/chains/evm/client/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ var erigon = ClientErrors{
var arbitrumFatal = regexp.MustCompile(`(: |^)(invalid message format|forbidden sender address)$|(: |^)(execution reverted)(:|$)`)
var arbitrum = ClientErrors{
// TODO: Arbitrum returns this in case of low or high nonce. Update this when Arbitrum fix it
// https://app.shortcut.com/chainlinklabs/story/16801/add-full-support-for-incorrect-nonce-on-arbitrum
// Archived ticket: story/16801/add-full-support-for-incorrect-nonce-on-arbitrum
NonceTooLow: regexp.MustCompile(`(: |^)invalid transaction nonce$|(: |^)nonce too low(:|$)`),
NonceTooHigh: regexp.MustCompile(`(: |^)nonce too high(:|$)`),
TerminallyUnderpriced: regexp.MustCompile(`(: |^)gas price too low$`),
Expand Down
2 changes: 1 addition & 1 deletion core/chains/evm/config/toml/defaults/Ethereum_Kovan.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ OperatorFactoryAddress = '0x8007e24251b1D2Fc518Eb843A701d9cD21fe0aA3'

[GasEstimator]
# FIXME: Kovan has strange behaviour with EIP1559, see:
# https://app.shortcut.com/chainlinklabs/story/34098/kovan-can-emit-blocks-that-violate-assumptions-in-block-history-estimator
# https://smartcontract-it.atlassian.net/browse/BCF-1420
EIP1559DynamicFees = false

[GasEstimator.BlockHistory]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ MinContractPayment = '0.1 link'

[GasEstimator]
# TODO: EIP1559 on rinkeby has not been adequately tested, see:
# https://app.shortcut.com/chainlinklabs/story/34098/kovan-can-emit-blocks-that-violate-assumptions-in-block-history-estimator
# https://smartcontract-it.atlassian.net/browse/BCF-1420
EIP1559DynamicFees = false

[GasEstimator.BlockHistory]
Expand Down
2 changes: 1 addition & 1 deletion core/chains/evm/forwarders/forwarder_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type FwdMgr struct {
logpoller evmlogpoller.LogPoller

// TODO(samhassan): sendersCache should be an LRU capped cache
// https://app.shortcut.com/chainlinklabs/story/37884/forwarder-manager-uses-lru-for-caching-dest-addresses
// https://smartcontract-it.atlassian.net/browse/ARCHIVE-22505
sendersCache map[common.Address][]common.Address
latestBlock int64

Expand Down
2 changes: 1 addition & 1 deletion core/services/keeper/upkeep_executer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ func Test_UpkeepExecuter_PerformsUpkeep_Happy(t *testing.T) {
head := newHead()
executer.OnNewLongestChain(testutils.Context(t), &head)
// TODO we want to see an errored run result once this is completed
// https://app.shortcut.com/chainlinklabs/story/25397/remove-failearly-flag-from-eth-call-task
// https://smartcontract-it.atlassian.net/browse/ARCHIVE-22186
cltest.AssertPipelineRunsStays(t, jb.PipelineSpecID, db, 0)
})

Expand Down
2 changes: 1 addition & 1 deletion core/services/ocr2/plugins/functions/reporting.go
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ func (r *functionsReporting) Report(ctx context.Context, ts types.ReportTimestam
}

// TODO: support per-request aggregation method
// https://app.shortcut.com/chainlinklabs/story/57701/per-request-plugin-config
// https://smartcontract-it.atlassian.net/browse/FUN-159
aggregated, errAgg := Aggregate(defaultAggMethod, observations)
if errAgg != nil {
r.logger.Error("FunctionsReporting Report: error when aggregating reqId", commontypes.LogFields{
Expand Down
2 changes: 1 addition & 1 deletion core/services/ocr2/validate/validate.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func validateSpec(ctx context.Context, tree *toml.Tree, spec job.Job, rc plugins
case types.OCR2Keeper:
return validateOCR2KeeperSpec(spec.OCR2OracleSpec.PluginConfig)
case types.Functions:
// TODO validator for DR-OCR spec: https://app.shortcut.com/chainlinklabs/story/54054/ocr-plugin-for-directrequest-ocr
// TODO validator for DR-OCR spec: https://smartcontract-it.atlassian.net/browse/FUN-112
return nil
case types.Mercury:
return validateOCR2MercurySpec(spec.OCR2OracleSpec.PluginConfig, *spec.OCR2OracleSpec.FeedID)
Expand Down
2 changes: 1 addition & 1 deletion core/services/pipeline/scheduler.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ func (s *scheduler) Run() {
result := <-s.resultCh
// TODO: if for some reason the cleanup didn't succeed and we're stuck waiting for reports forever
// we should be able to timeout and finish shutting down
// See: https://app.shortcut.com/chainlinklabs/story/21225/straighten-out-and-clarify-context-usage-in-the-pipeline
// See: https://smartcontract-it.atlassian.net/browse/BCF-994

s.waiting--

Expand Down
2 changes: 1 addition & 1 deletion core/web/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ func v2Routes(app chainlink.Application, r *gin.RouterGroup) {
{"cosmos", NewCosmosNodesController(app)},
} {
if chain.path == "evm" {
// TODO still EVM only https://app.shortcut.com/chainlinklabs/story/26276/multi-chain-type-ui-node-chain-configuration
// TODO still EVM only . Archive ticket: story/26276/multi-chain-type-ui-node-chain-configuration
nodes.GET("", paginatedRequest(chain.nc.Index))
}
nodes.GET(chain.path, paginatedRequest(chain.nc.Index))
Expand Down
Loading