Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship 1829 mode config #13373

Closed
wants to merge 15 commits into from
Closed

Ship 1829 mode config #13373

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1ad7d16
Adds Mode Sepolia config
davidcauchi May 5, 2024
d7b4d4a
Adds chaintype OP
davidcauchi May 6, 2024
cb6414c
Adds changeset
davidcauchi May 6, 2024
eae1f1d
Added mode mainnet
stackman27 May 30, 2024
f4ee1cd
update
stackman27 May 30, 2024
955a3ce
nit
stackman27 May 30, 2024
92041f7
historydepth
stackman27 May 30, 2024
bd770bd
updated config docs
stackman27 May 30, 2024
100c6b5
nit
stackman27 May 30, 2024
20210e3
Merge branch 'develop' into ship-1829-mode-config
stackman27 May 30, 2024
cb29123
nit
stackman27 May 30, 2024
81e6ee7
cleanup
stackman27 May 30, 2024
e36a9c8
amits feedback
stackman27 May 31, 2024
4548e46
updated changeset
stackman27 May 31, 2024
ea24f03
Merge branch 'develop' into ship-1829-mode-config
stackman27 Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-pears-fly.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": minor
---

#added Mode Sepolia config
stackman27 marked this conversation as resolved.
Show resolved Hide resolved
20 changes: 20 additions & 0 deletions core/chains/evm/config/toml/defaults/Blast_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
ChainID = '81457'
FinalityDepth = 200
FinalityTagEnabled = true
ChainType = 'optimismBedrock'

[GasEstimator]
EIP1559DynamicFees = true
BumpThreshold = 60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind this huge number?

BumpPercent = 20
Copy link
Collaborator

@dimriou dimriou Jun 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BumpPercent is already 20% https://github.com/smartcontractkit/chainlink/blob/develop/core/chains/evm/config/toml/defaults/fallback.toml#L42

BumpMin = '100 wei'
PriceMax = '120 gwei'
LimitDefault = 8000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback value is 500k, why do we set 8m here?

FeeCapDefault = '120 gwei'

[HeadTracker]
HistoryDepth = 300
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HistoryDepth is no longer needed to be larger than FinalityDepth #13494 . Perhaps we want to set this to something smaller?


[NodePool]
PollFailureThreshold = 2
PollInterval = '3s'
20 changes: 20 additions & 0 deletions core/chains/evm/config/toml/defaults/Blast_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
ChainID = '168587773'
FinalityDepth = 200
FinalityTagEnabled = true
ChainType = 'optimismBedrock'

[GasEstimator]
EIP1559DynamicFees = true
BumpThreshold = 60
BumpPercent = 20
BumpMin = '100 wei'
PriceMax = '120 gwei'
LimitDefault = 8000000
FeeCapDefault = '120 gwei'

[HeadTracker]
HistoryDepth = 300

[NodePool]
PollFailureThreshold = 2
PollInterval = '3s'
20 changes: 20 additions & 0 deletions core/chains/evm/config/toml/defaults/Mode_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
ChainID = '34443'
FinalityDepth = 200
FinalityTagEnabled = true
ChainType = 'optimismBedrock'

[GasEstimator]
EIP1559DynamicFees = true
BumpThreshold = 60
BumpPercent = 20
BumpMin = '100 wei'
PriceMax = '120 gwei'
LimitDefault = 8000000
FeeCapDefault = '120 gwei'

[HeadTracker]
HistoryDepth = 300

[NodePool]
PollFailureThreshold = 2
PollInterval = '3s'
20 changes: 20 additions & 0 deletions core/chains/evm/config/toml/defaults/Mode_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
ChainID = '919'
FinalityDepth = 200
FinalityTagEnabled = true
ChainType = 'optimismBedrock'

[GasEstimator]
EIP1559DynamicFees = true
BumpThreshold = 60
BumpPercent = 20
BumpMin = '100 wei'
PriceMax = '120 gwei'
LimitDefault = 8000000
FeeCapDefault = '120 gwei'

[HeadTracker]
HistoryDepth = 300

[NodePool]
PollFailureThreshold = 2
PollInterval = '3s'
Loading
Loading