Add account address pub key to fms chain config for Starknet #13421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eutopian
force-pushed
the
OPDATA-497/add-account-address-pub-key-for-starknet
branch
from
712cab6 to
354e0ce
Compare
eutopian
force-pushed
the
OPDATA-497/add-account-address-pub-key-for-starknet
branch
from
354e0ce to
96e7fa8
Compare
eutopian
force-pushed
the
OPDATA-497/add-account-address-pub-key-for-starknet
branch
from
96e7fa8 to
deb8dd1
Compare
eutopian
force-pushed
the
OPDATA-497/add-account-address-pub-key-for-starknet
branch
from
deb8dd1 to
5291708
Compare
augustbleeds
reviewed
Jun 4, 2024
core/services/feeds/orm_test.go
Outdated
| ChainType: feeds.ChainTypeEVM, | ||
| AccountAddress: "0x0001", | ||
| AdminAddress: "0x1001", | ||
| AccountAddressPublicKey: null.StringFrom("123"), |
There was a problem hiding this comment.
the public key would also be in hex format ("0x...."). might be helpful to clarify that by having "0x0100" as an example.
augustbleeds
reviewed
Jun 4, 2024
core/services/feeds/service_test.go
Outdated
| ChainID: "42", | ||
| ChainType: feeds.ChainTypeEVM, | ||
| AccountAddress: "0x0000000000000000000000000000000000000000", | ||
| AccountAddressPublicKey: null.StringFrom("4ef1e379910e567ac08cb3fee297595ae41aba618eb7257ecee5e6e53a35f9f4"), |
There was a problem hiding this comment.
yeah, let's prefix the hex value with 0x here as well for uniformity
augustbleeds
reviewed
Jun 4, 2024
| cfgID = int64(1) | ||
| chainID = "42" | ||
| accountAddr = "0x0000001" | ||
| acctAddrPubKey = "123" |
augustbleeds
previously approved these changes
Jun 4, 2024
eutopian
force-pushed
the
OPDATA-497/add-account-address-pub-key-for-starknet
branch
from
5291708 to
3bcec2a
Compare
eutopian
force-pushed
the
OPDATA-497/add-account-address-pub-key-for-starknet
branch
from
9b3fd31 to
ea6a6ad
Compare
eutopian
force-pushed
the
OPDATA-497/add-account-address-pub-key-for-starknet
branch
from
ea6a6ad to
4863024
Compare
augustbleeds
previously approved these changes
Jun 6, 2024
chris-de-leon-cll
previously approved these changes
Jun 6, 2024
Co-authored-by: Chris De Leon <[email protected]>
chris-de-leon-cll
approved these changes
Jun 6, 2024
augustbleeds
approved these changes
Jun 6, 2024
augustbleeds
pushed a commit
that referenced
this pull request
Jun 14, 2024
* add account address pub key to fms chain config for starknet * Update core/web/resolver/feeds_manager_chain_config.go Co-authored-by: Chris De Leon <[email protected]> --------- Co-authored-by: Chris De Leon <[email protected]>
augustbleeds
pushed a commit
that referenced
this pull request
Jun 14, 2024
* add account address pub key to fms chain config for starknet * Update core/web/resolver/feeds_manager_chain_config.go Co-authored-by: Chris De Leon <[email protected]> --------- Co-authored-by: Chris De Leon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starknet needs the pub key in the job spec, so we are sending it down to CLO via the chain config.