[Keystone] Minor bugfixes #13436
Merged
[Keystone] Minor bugfixes #13436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bolekk
commented
Jun 5, 2024
•
bolekk
commented
- Fix workflowName decoding in KeystoneFeedsConsumer.sol
- Fix potential panic in triggerSubscriber.UnregisterTrigger() (KS-225) and make (un)register idempotent
- Fix empty report check in write_target
- Some comment/log improvements
bolekk
force-pushed
the
bugfix/KS-256-fixes
branch
from
c417eab to
fe5fd33
Compare
1. Fix workflowName decoding in KeystoneFeedsConsumer.sol 2. Fix potential panic in triggerSubscriber.UnregisterTrigger() (KS-225) and make (un)register idempotent 3. Fix empty report check in write_target 4. Some comment/log improvements
bolekk
force-pushed
the
bugfix/KS-256-fixes
branch
from
97de409 to
6e6cca7
Compare
krehermann
reviewed
Jun 5, 2024
krehermann
reviewed
Jun 5, 2024
archseer
reviewed
Jun 6, 2024
Comment on lines
+91
to
+92
| // no shifting needed for bytes10 type | ||
| workflowName := mload(add(metadata, 64)) |
There was a problem hiding this comment.
Ah right, I fixed this in the forwarder but didn't realize there's a matching snippet in the consumer
krehermann
approved these changes
Jun 6, 2024
archseer
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.