Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dequeue minimum commitment of logs first - rework #13470

Closed
wants to merge 10 commits into from
Closed

Dequeue minimum commitment of logs first - rework #13470

wants to merge 10 commits into from

Conversation

ferglor
Copy link
Collaborator

@ferglor ferglor commented Jun 7, 2024 •
edited
Loading

  • Use a dequeueCoordinator to identify which block window we should dequeue from
    • The dequeueCoordinator examines each block window for minimum dequeue
    • If no window is eligible for minimum dequeue, the dequeue coordinator selects the oldest block window that still has logs to be dequeued for best effort

@ferglor ferglor requested a review from a team as a code owner June 7, 2024 23:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@ferglor ferglor changed the title Dequeue minimum commitment of logs first Dequeue minimum commitment of logs first - rework Jun 10, 2024
@ferglor ferglor force-pushed the feature/AUTO-10165-rework branch from 214b0c6 to 23440ff Compare June 10, 2024 21:13
@ferglor ferglor mentioned this pull request Jun 12, 2024
Closed
@ferglor ferglor force-pushed the feature/AUTO-9357 branch from 1bd9e84 to a6fb702 Compare June 15, 2024 13:05
@ferglor ferglor force-pushed the feature/AUTO-10165-rework branch from b1a9f33 to cb1013d Compare June 16, 2024 18:55
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@ferglor ferglor closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferglor