Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle reorgs in the provider - rework #13480

Closed
wants to merge 15 commits into from
Closed

Handle reorgs in the provider - rework #13480

wants to merge 15 commits into from

Conversation

ferglor
Copy link
Collaborator

@ferglor ferglor commented Jun 10, 2024 •
edited
Loading

Use the dequeueCoordinator to mark block windows as having been reorg'd

@ferglor ferglor requested a review from a team as a code owner June 10, 2024 12:15
@ferglor ferglor force-pushed the feature/AUTO-10165-rework branch from 214b0c6 to 23440ff Compare June 10, 2024 21:13
@ferglor ferglor force-pushed the feature/AUTO-10013-rework branch from 4cb35f4 to 0b1366f Compare June 10, 2024 21:25
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@ferglor ferglor force-pushed the feature/AUTO-10013-rework branch from 0b1366f to 538ad8d Compare June 10, 2024 21:30
ferglor added 3 commits June 10, 2024 22:51
@ferglor
Please linter
3a224b1
@ferglor
Lint
b1a9f33
@ferglor
WIP use a dequeue coordinator
e8eed1e 
WIP only dequeue upkeeps under the low limit

Update tests

WIP tests

Add tests

Switch to a new structure of storing logs by block number, update tests

Update tests, track reorgs by comparing block hashes, mark as missing min dequeue in coordinator

Add tests showing reorg handling
@ferglor ferglor force-pushed the feature/AUTO-10013-rework branch from 538ad8d to e8eed1e Compare June 10, 2024 22:14
@ferglor ferglor mentioned this pull request Jun 12, 2024
Closed
@ferglor ferglor force-pushed the feature/AUTO-10165-rework branch from b1a9f33 to cb1013d Compare June 16, 2024 18:55
@ferglor ferglor closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferglor