Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HistoryDepth to FinalityDepth validation #13494

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Remove HistoryDepth to FinalityDepth validation #13494

merged 1 commit into from
Jun 14, 2024

Conversation

HelloKashif
Copy link
Contributor

@HelloKashif HelloKashif commented Jun 11, 2024 •
edited
Loading

  1. Remove HistoryDepth must be greater than FinalityDepth validation check
  2. Update tests/docs

Context: https://chainlink-core.slack.com/archives/C03ANJB9VB7/p1714397285801799?thread_ts=1714395771.022789&cid=C03ANJB9VB7

@HelloKashif HelloKashif requested a review from dimriou June 11, 2024 03:54
@HelloKashif HelloKashif requested review from a team as code owners June 11, 2024 03:54
@HelloKashif HelloKashif force-pushed the kashif/history-depth branch from ec19423 to 44724ac Compare June 11, 2024 03:57
@HelloKashif HelloKashif force-pushed the kashif/history-depth branch from 44724ac to 468c6ed Compare June 11, 2024 04:13
@HelloKashif HelloKashif force-pushed the kashif/history-depth branch from 468c6ed to 849958d Compare June 12, 2024 01:31
@HelloKashif HelloKashif force-pushed the kashif/history-depth branch from 849958d to 7d09fa8 Compare June 12, 2024 01:34
@HelloKashif HelloKashif requested a review from dimriou June 12, 2024 01:56
@dimriou dimriou added this pull request to the merge queue Jun 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 14, 2024
@dimriou dimriou added this pull request to the merge queue Jun 14, 2024
Merged via the queue into develop with commit a830fe0 Jun 14, 2024
106 checks passed
@dimriou dimriou deleted the kashif/history-depth branch June 14, 2024 14:25
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Draft
@dimriou dimriou mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaidashenko dhaidashenko dhaidashenko approved these changes

@dimriou dimriou dimriou approved these changes

@simsonraj simsonraj simsonraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HelloKashif @simsonraj @dimriou @dhaidashenko