Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verb formatting in the chainlink/v2/core/logger.Logger outputs. #13495

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Fix verb formatting in the chainlink/v2/core/logger.Logger outputs. #13495

merged 6 commits into from
Jun 13, 2024

Conversation

pavel-raykov
Copy link
Collaborator

@pavel-raykov pavel-raykov commented Jun 11, 2024 •
edited
Loading

This PR 1. fixes existing warnings in the log formatting, 2. enables govet printf linter on the chainlink/v2/core/logger.Logger class.

@pavel-raykov pavel-raykov changed the title Fix verb formatting in the log outputs. Fix verb formatting in the chainlink/v2/core/logger.Logger outputs. Jun 11, 2024
@pavel-raykov pavel-raykov marked this pull request as ready for review June 11, 2024 11:46
@pavel-raykov pavel-raykov requested review from a team as code owners June 11, 2024 11:46
@pavel-raykov pavel-raykov requested a review from jmank88 June 11, 2024 11:47
jmank88
jmank88 previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@jmank88 jmank88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's get some of the other authors to ack that this is what they intended since some cases are ambiguous (and they might want to have an "err" key/val to filter/query for).

@pavel-raykov pavel-raykov requested review from ferglor and jmank88 June 12, 2024 16:27
jmank88
jmank88 previously approved these changes Jun 12, 2024
View reviewed changes
ferglor
ferglor previously approved these changes Jun 12, 2024
View reviewed changes
@pavel-raykov pavel-raykov dismissed stale reviews from ferglor and jmank88 via 7024b2a June 13, 2024 06:21
@pavel-raykov pavel-raykov requested review from jmank88 and ferglor June 13, 2024 08:11
@george-dorin george-dorin added this pull request to the merge queue Jun 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2024
@ferglor ferglor added this pull request to the merge queue Jun 13, 2024
Merged via the queue into develop with commit 483ee6a Jun 13, 2024
106 checks passed
@ferglor ferglor deleted the BCF-3255-create-golangci-lint-rule-for-vetting-logger-args branch June 13, 2024 16:05
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferglor ferglor ferglor approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-raykov @jmank88 @ferglor