Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decoding unnamed params, the return type was right, but names weren't populated for the arg itself. #13512

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Fix decoding unnamed params, the return type was right, but names weren't populated for the arg itself. #13512

merged 4 commits into from
Jun 12, 2024

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Jun 11, 2024

No description provided.

@nolag nolag requested a review from a team as a code owner June 11, 2024 16:16
@nolag nolag force-pushed the rtinianov_unnamedAgain branch from d0bbb88 to 2f4af5f Compare June 11, 2024 17:32
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@nolag nolag force-pushed the rtinianov_unnamedAgain branch from 2f4af5f to a9390bf Compare June 11, 2024 17:54
@nolag nolag force-pushed the rtinianov_unnamedAgain branch from 4a19216 to f7af645 Compare June 12, 2024 15:39
@nolag nolag enabled auto-merge June 12, 2024 15:58
@nolag nolag added this pull request to the merge queue Jun 12, 2024
Merged via the queue into develop with commit 2db7369 Jun 12, 2024
105 of 106 checks passed
@nolag nolag deleted the rtinianov_unnamedAgain branch June 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@reductionista reductionista reductionista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nolag @reductionista @cedric-cordenier