Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCF-3258 - Fix QueryKey test case flakiness #13529

Merged
merged 2 commits into from
Jun 18, 2024
Merged

BCF-3258 - Fix QueryKey test case flakiness #13529

merged 2 commits into from
Jun 18, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Jun 12, 2024

@ilija42 ilija42 requested a review from a team as a code owner June 12, 2024 13:31
@ilija42 ilija42 mentioned this pull request Jun 12, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 81d0feb to 7c81a39 Compare June 12, 2024 13:53
@ilija42 ilija42 requested a review from a team as a code owner June 12, 2024 13:56
@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 6475af5 to 90f15a4 Compare June 12, 2024 14:00
@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 90f15a4 to 8dfcaa7 Compare June 13, 2024 11:36
@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 0f5d52c to 0304e97 Compare June 14, 2024 13:31
@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 0304e97 to 271404d Compare June 17, 2024 12:49
@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 271404d to 01466f7 Compare June 17, 2024 14:59
@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 01466f7 to fd82c96 Compare June 17, 2024 16:09
@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from fd82c96 to c2b25fe Compare June 17, 2024 16:22
@ilija42 ilija42 requested a review from a team as a code owner June 17, 2024 16:22
EasterTheBunny
EasterTheBunny previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@EasterTheBunny EasterTheBunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from c63cd5e to e61a9da Compare June 17, 2024 16:31
@ilija42 ilija42 requested a review from a team as a code owner June 17, 2024 16:31
@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 760e792 to 67f5513 Compare June 17, 2024 16:46
@ilija42 ilija42 requested a review from EasterTheBunny June 17, 2024 17:03
@ilija42 ilija42 enabled auto-merge June 17, 2024 17:08
krehermann
krehermann previously approved these changes Jun 17, 2024
View reviewed changes
patrickhuie19
patrickhuie19 previously approved these changes Jun 17, 2024
View reviewed changes
@ilija42 ilija42 added this pull request to the merge queue Jun 17, 2024
EasterTheBunny
EasterTheBunny previously approved these changes Jun 17, 2024
View reviewed changes
@ilija42 ilija42 removed this pull request from the merge queue due to a manual request Jun 17, 2024
yongkangchia
yongkangchia previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@yongkangchia yongkangchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes to core

@ilija42 ilija42 force-pushed the BCF-3258-fix-flaky-queryKey-test branch from 67f5513 to 002dceb Compare June 18, 2024 09:58
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ilija42 ilija42 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into develop with commit e56d5d6 Jun 18, 2024
107 of 108 checks passed
@ilija42 ilija42 deleted the BCF-3258-fix-flaky-queryKey-test branch June 18, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongkangchia yongkangchia yongkangchia approved these changes

@george-dorin george-dorin george-dorin approved these changes

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@krehermann krehermann Awaiting requested review from krehermann

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilija42 @EasterTheBunny @krehermann @patrickhuie19 @george-dorin @yongkangchia