Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KS-340] Stop hardcoding DON ID in workflow engine #13549

Merged
merged 6 commits into from
Jun 15, 2024
Merged

[KS-340] Stop hardcoding DON ID in workflow engine #13549

merged 6 commits into from
Jun 15, 2024

Conversation

cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Jun 14, 2024 •
edited
Loading

Ticket

https://smartcontract-it.atlassian.net/browse/KS-340

Requires Dependencies

Resolves Dependencies

ettec
ettec reviewed Jun 14, 2024
View reviewed changes
core/capabilities/reader.go Outdated
}
}

if len(dons) > 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how would this situation arise OOI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't -- @DeividasK is modifying the contract so that each node has only one WorkflowDON so I've removed the log and just fetching the first one in the list

@cedric-cordenier cedric-cordenier force-pushed the stop-hardcoding-don-id branch 5 times, most recently from 236fd7e to 8920823 Compare June 14, 2024 12:55
@cedric-cordenier cedric-cordenier force-pushed the stop-hardcoding-don-id branch from 8920823 to 8e5d649 Compare June 14, 2024 12:58
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cedric-cordenier cedric-cordenier marked this pull request as ready for review June 14, 2024 13:24
@cedric-cordenier cedric-cordenier requested review from a team as code owners June 14, 2024 13:24
DeividasK
DeividasK previously approved these changes Jun 14, 2024
View reviewed changes
krehermann
krehermann previously approved these changes Jun 14, 2024
View reviewed changes
bolekk
bolekk reviewed Jun 14, 2024
View reviewed changes
core/capabilities/reader.go Outdated

var workflowDON capabilities.DON
if len(workflowDONs) > 0 {
workflowDON = workflowDONs[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that possible? Should we at least log a warning?

Copy link
Contributor Author

@cedric-cordenier cedric-cordenier Jun 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bolekk We discussed with @DeividasK that it shouldn't be possible; there should be exactly one workflowDON

let me tighten up this logic a bit though

@cedric-cordenier cedric-cordenier dismissed stale reviews from krehermann and DeividasK via 95ff92f June 14, 2024 15:15
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jun 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 14, 2024
@bolekk bolekk added this pull request to the merge queue Jun 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 15, 2024
@bolekk bolekk added this pull request to the merge queue Jun 15, 2024
Merged via the queue into develop with commit f296311 Jun 15, 2024
107 of 108 checks passed
@bolekk bolekk deleted the stop-hardcoding-don-id branch June 15, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ettec ettec ettec approved these changes

@krehermann krehermann krehermann approved these changes

@bolekk bolekk Awaiting requested review from bolekk

@DeividasK DeividasK Awaiting requested review from DeividasK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cedric-cordenier @bolekk @DeividasK @krehermann @ettec