Ks 296 dispatcher context and threading #13551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
previously approved these changes
Jun 14, 2024
ettec
force-pushed
the
ks-296-dispatcher-context-and-threading
branch
from
f9919ee to
db1e3e2
Compare
ettec
force-pushed
the
ks-296-dispatcher-context-and-threading
branch
from
db1e3e2 to
77606da
Compare
ettec
force-pushed
the
ks-296-dispatcher-context-and-threading
branch
from
77606da to
40ee34a
Compare
ettec
force-pushed
the
ks-296-dispatcher-context-and-threading
branch
from
0c0b151 to
f3f2225
Compare
|
krehermann
approved these changes
Jun 14, 2024
bolekk
approved these changes
Jun 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The threading model chosen is one thread per capability, reasoning for this is as follows:
Prevents a 'dodgy' capability impacting others within the node by blocking the receive thread
Makes it easy to monitor per capability performance by monitoring the receive queue size
This third benefit is debatable, small and something we may want to revisit once we understand with experience how load should be balanced across capabilities.....having said that....initally at least it is advantageous to have the Receive method of the capabilities single threaded as it keeps things relatively simple and easier to reason about should we encounter any issues.
jira issue: https://smartcontract-it.atlassian.net/browse/KS-296
#13524. depends on this PR.