-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KS-368] keystone/workflow engine logging #13563
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9f79c75
Remove unused logger arg
HenryNguyen5 8b15975
Make capability id logging consistent
HenryNguyen5 7e62b98
Clean up init logs
HenryNguyen5 5a76863
Normalize executionID and capabilityID
HenryNguyen5 3f23346
Adding store level logging
HenryNguyen5 2fb4f49
Add changeset
HenryNguyen5 dd5d23f
Add custom errors to workflow engine
HenryNguyen5 3b559a6
Remove wrapped variants of logging
HenryNguyen5 cef3bb2
Simplify error handling for workflow engine errors
HenryNguyen5 3294247
Change indentation
HenryNguyen5 0083d17
Run linter
HenryNguyen5 175b006
Remove trailing newline
HenryNguyen5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"chainlink": patch | ||
--- | ||
|
||
#internal Clean up workflow engine logging |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -353,7 +353,7 @@ func NewApplication(opts ApplicationOpts) (Application, error) { | |
jobORM = job.NewORM(opts.DS, pipelineORM, bridgeORM, keyStore, globalLogger) | ||
txmORM = txmgr.NewTxStore(opts.DS, globalLogger) | ||
streamRegistry = streams.NewRegistry(globalLogger, pipelineRunner) | ||
workflowORM = workflowstore.NewDBStore(opts.DS, clockwork.NewRealClock()) | ||
workflowORM = workflowstore.NewDBStore(opts.DS, globalLogger, clockwork.NewRealClock()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This adds a logger to our ORM, i found it pretty useful when debugging failing tests |
||
) | ||
|
||
for _, chain := range legacyEVMChains.Slice() { | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this so we can log the capability ID that is being wrapped. I didn't want to waste a grpc call on
Info
when we already have this information