add limiter for no values to upsert #13650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
|
jmank88
reviewed
Jun 21, 2024
| if len(values) == 0 { | ||
| return | ||
| } | ||
|
|
||
| if err := c.ORM.BulkUpsertBridgeResponse(context.Background(), values); err != nil { |
There was a problem hiding this comment.
Out of scope, but we can do better than Background here. Let's circle back to upgrade the stop chan to a StopChan in order to spawn a Context to pass here (or from the caller).
jmank88
approved these changes
Jun 21, 2024
krehermann
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk upsert was attempting to run with an empty list, resulting in repeated errors. This fix does a length check before attempting to upsert.