Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KS-391: Capabilities registry reentrancy fix #13970

Merged
merged 8 commits into from
Aug 9, 2024
Merged

KS-391: Capabilities registry reentrancy fix #13970

merged 8 commits into from
Aug 9, 2024

Conversation

cds95
Copy link
Contributor

@cds95 cds95 commented Jul 31, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited
Loading

LCOV of commit 445aad5 during Solidity Foundry #41300

Summary coverage rate:
  lines......: 98.7% (1838 of 1862 lines)
  functions..: 96.6% (344 of 356 functions)
  branches...: 90.7% (782 of 862 branches)

Files changed coverage rate: n/a

@cds95 cds95 marked this pull request as ready for review July 31, 2024 12:57
@cds95 cds95 requested review from archseer, bolekk, patrick-dowell and a team as code owners July 31, 2024 12:57
@DeividasK DeividasK changed the title KS-391: Capabilities registry audit fixes KS-391: Capabilities registry reentrancy fix Jul 31, 2024
DeividasK
DeividasK previously approved these changes Aug 8, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@DeividasK DeividasK enabled auto-merge August 9, 2024 12:26
@DeividasK DeividasK added this pull request to the merge queue Aug 9, 2024
Merged via the queue into develop with commit cefbb09 Aug 9, 2024
120 checks passed
@DeividasK DeividasK deleted the KS-391/capabilities-registry-audit-fixes branch August 9, 2024 13:03
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Draft
This was referenced Aug 18, 2024
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeividasK DeividasK DeividasK approved these changes

@archseer archseer archseer approved these changes

@bolekk bolekk Awaiting requested review from bolekk

@patrick-dowell patrick-dowell Awaiting requested review from patrick-dowell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cds95 @archseer @DeividasK