-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHIP-2586] Update Polygon config PIP-35 #14014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelloKashif
previously approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Madalosso
force-pushed
the
polygon-pip35-config
branch
from
August 2, 2024 17:54
ed21f36
to
f8b5a37
Compare
Madalosso
force-pushed
the
polygon-pip35-config
branch
from
August 5, 2024 13:22
f8b5a37
to
59cd836
Compare
Madalosso
changed the title
Update Polygon config PIP-35
[SHIP-2586] Update Polygon config PIP-35
Aug 5, 2024
amit-momin
previously approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
silaslenihan
previously approved these changes
Aug 5, 2024
Madalosso
force-pushed
the
polygon-pip35-config
branch
from
August 5, 2024 15:24
315dab3
to
7e1b022
Compare
jmank88
reviewed
Aug 5, 2024
Madalosso
force-pushed
the
polygon-pip35-config
branch
from
August 5, 2024 15:38
7e1b022
to
3fbb1a7
Compare
Madalosso
force-pushed
the
polygon-pip35-config
branch
from
August 5, 2024 15:38
3fbb1a7
to
7068cdb
Compare
jmank88
approved these changes
Aug 5, 2024
Madalosso
force-pushed
the
polygon-pip35-config
branch
from
August 5, 2024 17:49
25f7756
to
044e1d3
Compare
amit-momin
approved these changes
Aug 5, 2024
Madalosso
force-pushed
the
polygon-pip35-config
branch
from
August 5, 2024 18:14
021dc84
to
47c1a2d
Compare
Quality Gate passedIssues Measures |
silaslenihan
approved these changes
Aug 5, 2024
prashantkumar1982
approved these changes
Aug 6, 2024
momentmaker
added a commit
that referenced
this pull request
Aug 6, 2024
* develop: Add finalizer component to TXM (#13638) auto: adjust cron contract imports (#13927) Set PriceMin to match pip-35 definition (#14014) update solana e2e test build deps (#13978) fix data race in syncer/launcher (#14050) [KS-411] Extra validation for FeedIDs in Streams Codec (#14038) [TT-1262] dump pg on failure (#14029) ks-409 fix the mock trigger to ensure events are sent (#14047) update readme's with information about CL node TOML config (#14028) [CCIP-Merge] OCR2 plugins [CCIP-2942] (#14043) [BCF - 3339] - Codec and CR hashed topics support (#14016) common version update to head of develop (#14030)
This was referenced Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHIP-2586
Updates toml values for polygon testnets to match PIP-35 resolution (set PriceMin to 25gwei).
Since mainnet PriceMin was already set to 30gwei, I chose not to change it. (comments around the 30gwei value led me to assume that RPC providers already require such amount to prevent spam)