Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIP-2586] Update Polygon config PIP-35 #14014

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Madalosso
Copy link
Contributor

@Madalosso Madalosso commented Aug 2, 2024

SHIP-2586
Updates toml values for polygon testnets to match PIP-35 resolution (set PriceMin to 25gwei).
Since mainnet PriceMin was already set to 30gwei, I chose not to change it. (comments around the 30gwei value led me to assume that RPC providers already require such amount to prevent spam)

@Madalosso Madalosso requested a review from a team as a code owner August 2, 2024 13:22
HelloKashif
HelloKashif previously approved these changes Aug 2, 2024
Copy link
Contributor

@HelloKashif HelloKashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Madalosso Madalosso force-pushed the polygon-pip35-config branch from ed21f36 to f8b5a37 Compare August 2, 2024 17:54
@Madalosso Madalosso force-pushed the polygon-pip35-config branch from f8b5a37 to 59cd836 Compare August 5, 2024 13:22
@Madalosso Madalosso changed the title Update Polygon config PIP-35 [SHIP-2586] Update Polygon config PIP-35 Aug 5, 2024
@Madalosso Madalosso requested a review from a team as a code owner August 5, 2024 13:58
amit-momin
amit-momin previously approved these changes Aug 5, 2024
Copy link
Contributor

@amit-momin amit-momin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

silaslenihan
silaslenihan previously approved these changes Aug 5, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into develop with commit c2c31c0 Aug 6, 2024
121 checks passed
@prashantkumar1982 prashantkumar1982 deleted the polygon-pip35-config branch August 6, 2024 18:24
momentmaker added a commit that referenced this pull request Aug 6, 2024
* develop:
  Add finalizer component to TXM (#13638)
  auto: adjust cron contract imports (#13927)
  Set PriceMin to match pip-35 definition (#14014)
  update solana e2e test build deps (#13978)
  fix data race in syncer/launcher (#14050)
  [KS-411] Extra validation for FeedIDs in Streams Codec (#14038)
  [TT-1262] dump pg on failure (#14029)
  ks-409 fix the mock trigger to ensure events are sent (#14047)
  update readme's with information about CL node TOML config (#14028)
  [CCIP-Merge] OCR2 plugins  [CCIP-2942] (#14043)
  [BCF - 3339] - Codec and CR hashed topics support (#14016)
  common version update to head of develop (#14030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants