Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-10161: implement without zksync forwarder interface change #14037

Merged
merged 25 commits into from
Aug 22, 2024
Merged

auto-10161: implement without zksync forwarder interface change #14037

merged 25 commits into from
Aug 22, 2024

Conversation

FelixFan1992
Copy link
Contributor

Requires Dependencies

Resolves Dependencies

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024 •
edited
Loading

LCOV of commit 7b24db0 during Solidity Foundry #41348

Summary coverage rate:
  lines......: 98.7% (1838 of 1862 lines)
  functions..: 96.6% (344 of 356 functions)
  branches...: 90.7% (782 of 862 branches)

Files changed coverage rate: n/a

@FelixFan1992 FelixFan1992 marked this pull request as ready for review August 6, 2024 19:47
@FelixFan1992 FelixFan1992 requested review from a team and RensR as code owners August 6, 2024 19:47
@FelixFan1992 FelixFan1992 changed the base branch from auto-10161-replication to develop August 6, 2024 20:37
@FelixFan1992 FelixFan1992 changed the base branch from develop to auto-10161-replication August 6, 2024 20:38
@FelixFan1992 FelixFan1992 requested review from a team as code owners August 6, 2024 20:43
@FelixFan1992 FelixFan1992 changed the base branch from auto-10161-replication to develop August 6, 2024 20:44
@FelixFan1992 FelixFan1992 changed the base branch from develop to auto-10161-replication August 6, 2024 20:45
@FelixFan1992 FelixFan1992 removed request for a team and RensR August 6, 2024 20:46
@FelixFan1992 FelixFan1992 force-pushed the auto-10161-no-forwarder-update branch from a695363 to 9860f7c Compare August 6, 2024 20:48
Base automatically changed from auto-10161-replication to develop August 7, 2024 15:45
@FelixFan1992 FelixFan1992 force-pushed the auto-10161-no-forwarder-update branch from 9860f7c to aefeeaf Compare August 7, 2024 16:08
infiloop2
infiloop2 reviewed Aug 15, 2024
View reviewed changes
contracts/src/v0.8/automation/ZKSyncAutomationForwarder.sol Outdated
Comment on lines 56 to 57
if (gasUsed > gasAmount) {
return (false, gasUsed);
Copy link
Contributor

@infiloop2 infiloop2 Aug 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the pubData gas be still charged by zksync in this case, causing the whole tx to fail by running out of gas

@FelixFan1992 FelixFan1992 requested a review from infiloop2 August 16, 2024 20:02
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
5 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarQube

@infiloop2 infiloop2 requested a review from shileiwill August 22, 2024 14:54
@FelixFan1992 FelixFan1992 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into develop with commit 9c240b6 Aug 22, 2024
83 of 85 checks passed
@FelixFan1992 FelixFan1992 deleted the auto-10161-no-forwarder-update branch August 22, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiloop2 infiloop2 infiloop2 approved these changes

@shileiwill shileiwill shileiwill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelixFan1992 @shileiwill @infiloop2