Improve TXM performance by optimize Confirmer and Finalizer queries to stop pulling EVM receipt #14039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-query-to-skip-evm-receipt
…er-query-to-skip-evm-receipt
…er-query-to-skip-evm-receipt
amit-momin
reviewed
Aug 7, 2024
…er-query-to-skip-evm-receipt
…er-query-to-skip-evm-receipt
dimriou
reviewed
Aug 20, 2024
…er-query-to-skip-evm-receipt
dimriou
reviewed
Aug 21, 2024
dimriou
reviewed
Aug 21, 2024
dimriou
reviewed
Aug 21, 2024
…er-query-to-skip-evm-receipt
…er-query-to-skip-evm-receipt
dimriou
approved these changes
Aug 22, 2024
amit-momin
approved these changes
Aug 22, 2024
…er-query-to-skip-evm-receipt
|
prashantkumar1982
approved these changes
Aug 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
prashantkumar1982
deleted the
BCI-3905/update-txm-confirmer-and-finalizer-query-to-skip-evm-receipt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Improve TXM performance by optimize Confirmer and Finalizer queries to stop pulling EVM receipt
Jira link: BCI-3905
Requires Dependencies:
Depend on finalizer PR, will update after it gets merged.
Description
The CCIP investigation into the TXM’s CPU and memory usage identified that the FindTransactionsConfirmedInBlockRange was the biggest offender. More specifically, pulling the EVM receipt from the DB is the most costly operation. Investigate if the EVM receipt is needed and, if not, update the query to only pull the required fields. At first glance, it seems that only BlockNumber, BlockHash, and TransactionIndex are required which are all stored directly in the receipt table.
The Finalizer introduces a new query that also pulls receipts from the DB. The same optimization could be applied to its FindConfirmedTxesReceipts query as well.
Acceptance Criteria
Determine if the Confirmer re-org detection logic requires fields from the EVM receipt json that are not already present in the receipts table. If it does not, update the query to stop pulling this field
Determine if the Finalizer requires fields from the EVM receipt json that are not already present in the receipts table. If it does not, update the query to stop pulling this field